Add a flag to crawl only the root website #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indrajithi
reviewed
Jun 15, 2024
| @@ -53,6 +55,8 @@ def __init__(self, | |||
| self.max_workers: int = max_workers | |||
| self.delay: float = delay | |||
| self.verbose: bool = verbose | |||
| self.stay_within_domain: bool = stay_within_domain | |||
There was a problem hiding this comment.
Could we use the name internal_links_only as a flag because I want to provide option for crawling external links later which can be named as external_links_only. WDYT?
|
Also please check this |
indrajithi
reviewed
Jun 15, 2024
| print(Fore.GREEN + f"Crawling: {root_url}") | ||
| crawler.start() | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| main() | ||
| main() |
There was a problem hiding this comment.
Also this missing last new line is causing lint to fail.
There was a problem hiding this comment.
Also please add a test case. Thanks!
|
Closing due to inactivity. /cc @Mews @devavinothm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Changes
Added stay_within_domain Parameter:
Stored Root Domain:
Filtered Links:
I hope this solves the issue.