-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CECO-1860][DatadogGenericResource] Add monitor support #1635
base: tbavelier/levan-m/generic-resoource-refactor
Are you sure you want to change the base?
[CECO-1860][DatadogGenericResource] Add monitor support #1635
Conversation
… (and associated test)
…elier/add_generic_resource_monitors
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## tbavelier/levan-m/generic-resoource-refactor #1635 +/- ##
================================================================================
- Coverage 48.96% 48.79% -0.17%
================================================================================
Files 217 218 +1
Lines 20880 20950 +70
================================================================================
Hits 10223 10223
- Misses 10117 10187 +70
Partials 540 540
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
What does this PR do?
DatadogGenericResource
Motivation
Additional Notes
This is based on refactor introduced in #1634
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Same as #1534 but using the object in Motivation: test the whole lifecycle of the object: create, update, (optionally: update from UI (waiting for the forcesync)), delete
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label