Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CECO-1860][DatadogGenericResource] Refactor handler 2 #1640

Open
wants to merge 4 commits into
base: tbavelier/levan-m/generic-resoource-refactor
Choose a base branch
from

Conversation

tbavelier
Copy link
Member

What does this PR do?

Refactors CRUD operations

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

QA to be done on the "main" PR that will be merged

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 4.76190% with 120 lines in your changes missing coverage. Please review.

Project coverage is 48.91%. Comparing base (049c0b0) to head (090df80).

Files with missing lines Patch % Lines
...nternal/controller/datadoggenericresource/utils.go 4.00% 48 Missing ⚠️
...al/controller/datadoggenericresource/synthetics.go 0.00% 47 Missing ⚠️
...nal/controller/datadoggenericresource/notebooks.go 13.79% 25 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                               Coverage Diff                                @@
##           tbavelier/levan-m/generic-resoource-refactor    #1640      +/-   ##
================================================================================
- Coverage                                         48.96%   48.91%   -0.05%     
================================================================================
  Files                                               217      217              
  Lines                                             20880    20903      +23     
================================================================================
+ Hits                                              10223    10225       +2     
- Misses                                            10117    10138      +21     
  Partials                                            540      540              
Flag Coverage Δ
unittests 48.91% <4.76%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nal/controller/datadoggenericresource/notebooks.go 11.47% <13.79%> (+0.36%) ⬆️
...al/controller/datadoggenericresource/synthetics.go 37.75% <0.00%> (+6.66%) ⬆️
...nternal/controller/datadoggenericresource/utils.go 53.39% <4.00%> (-39.59%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 049c0b0...090df80. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants