[CI Visibility] Test session logical names #6050
Merged
+144
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the configuration value to the config_norm_rules.json
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6050) - mean (69ms) : 67, 71
. : milestone, 69,
master - mean (71ms) : 66, 75
. : milestone, 71,
section CallTarget+Inlining+NGEN
This PR (6050) - mean (1,137ms) : 1003, 1272
. : milestone, 1137,
master - mean (1,107ms) : 1076, 1137
. : milestone, 1107,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6050) - mean (108ms) : 105, 111
. : milestone, 108,
master - mean (110ms) : 107, 113
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (6050) - mean (785ms) : 745, 825
. : milestone, 785,
master - mean (804ms) : 782, 825
. : milestone, 804,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6050) - mean (92ms) : 90, 94
. : milestone, 92,
master - mean (94ms) : 91, 97
. : milestone, 94,
section CallTarget+Inlining+NGEN
This PR (6050) - mean (738ms) : 714, 762
. : milestone, 738,
master - mean (753ms) : 734, 773
. : milestone, 753,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6050) - mean (191ms) : 189, 194
. : milestone, 191,
master - mean (191ms) : 186, 195
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6050) - mean (1,204ms) : 1176, 1232
. : milestone, 1204,
master - mean (1,194ms) : 1158, 1229
. : milestone, 1194,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6050) - mean (277ms) : 273, 281
. : milestone, 277,
master - mean (276ms) : 271, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6050) - mean (953ms) : 932, 974
. : milestone, 953,
master - mean (963ms) : 939, 987
. : milestone, 963,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6050) - mean (266ms) : 263, 269
. : milestone, 266,
master - mean (265ms) : 260, 271
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6050) - mean (938ms) : 911, 964
. : milestone, 938,
master - mean (942ms) : 917, 966
. : milestone, 942,
|
| @@ -372,6 +372,7 @@ | |||
| "DD_CIVISIBILITY_EARLY_FLAKE_DETECTION_ENABLED": "ci_visibility_early_flake_detection_enabled", | |||
| "DD_CIVISIBILITY_CODE_COVERAGE_COLLECTORPATH": "ci_visibility_code_coverage_collectorpath", | |||
| "DD_CIVISIBILITY_RUM_FLUSH_WAIT_MILLIS": "ci_visibility_rum_flush_wait_millis", | |||
| "DD_TEST_SESSION_NAME": "test_session_name", | |||
There was a problem hiding this comment.
I usually add the corresponding dd-go PR link to the PR's description so people don't complaint about it missing XD
There was a problem hiding this comment.
Good one, here it is: https://github.com/DataDog/dd-go/pull/150765
Benchmarks Report for tracer 🐌Benchmarks for #6050 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️Raw results
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6050) (10.942M) : 0, 10941686
master (11.137M) : 0, 11137434
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (6050) (7.300M) : 0, 7300227
master (7.472M) : 0, 7472267
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.740M) : 0, 7739506
section Manual
master (11.147M) : 0, 11147376
section Manual + Automatic
This PR (6050) (6.738M) : 0, 6737852
master (6.885M) : 0, 6884909
section DD_TRACE_ENABLED=0
master (10.298M) : 0, 10297627
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6050) (9.566M) : 0, 9565630
master (9.458M) : 0, 9457862
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (6050) (6.366M) : 0, 6366076
master (6.697M) : 0, 6697227
section Trace stats
master (6.870M) : 0, 6870399
section Manual
master (9.399M) : 0, 9399390
section Manual + Automatic
This PR (6050) (6.171M) : 0, 6171273
master (6.259M) : 0, 6258620
section DD_TRACE_ENABLED=0
master (8.951M) : 0, 8950555
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6050) (10.128M) : 0, 10128193
master (9.738M) : 0, 9737750
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (6050) (6.663M) : 0, 6663006
master (6.696M) : 0, 6696467
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.292M) : 0, 7291705
section Manual
master (9.976M) : 0, 9975574
section Manual + Automatic
This PR (6050) (6.055M) : 0, 6055476
master (6.215M) : 0, 6215400
section DD_TRACE_ENABLED=0
master (9.307M) : 0, 9307213
|
anmarchenko
approved these changes
Sep 19, 2024
bouwkast
approved these changes
Sep 19, 2024
tonyredondo
deleted the
tony/civisibility-test-session-logical-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR implements a new CI Visibility feature called Test session logical names. In this feature a new DD_TEST_SESSION_NAME environment variable is introduced for customer to set their custom test session name. This name is sent to the backend inside the
metadataobject in the CI Visibility protocol.PR to change the intake json: https://github.com/DataDog/dd-go/pull/150765
Reason for change
New feature: https://docs.google.com/document/d/1XPBDDIMUxzfkko66vXIEjoi4xbCamTz-Bv6ChSR8jys/edit
Implementation details
CIEventMessagePackFormatterto include this new tag inside the metadata object.Test coverage
Added a
metadatavalidator in the EVP tests (CI Visibility protocol)