Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serverless] trigger consolidated pipeline on tags #6052

Merged
merged 1 commit into from
Sep 18, 2024
Merged

[serverless] trigger consolidated pipeline on tags #6052

merged 1 commit into from
Sep 18, 2024
+0 −1

Conversation

duncanista
Copy link
Contributor

Summary of changes

Removes exclusion of pipeline trigger for tags.

Reason for change

Serverless requires a build on a tag in order to have a production ready pipeline to use.

Implementation details

n/a

Test coverage

Other details

@duncanista duncanista requested a review from a team as a code owner September 18, 2024 14:41
@github-actions github-actions bot added area:builds project files, build scripts, pipelines, versioning, releases, packages area:serverless labels Sep 18, 2024
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Sep 18, 2024 •
edited
Loading

Datadog Report

Branch report: jordan.gonzalez/trigger-pipeline-on-tags
Commit report: aec368c
Test service: dd-trace-dotnet

✅ 0 Failed, 363753 Passed, 2053 Skipped, 15h 49m 7.8s Total Time
❄️ 1 New Flaky
⌛ 1 Performance Regression

New Flaky Tests (1)

  • RunTest - Datadog.Trace.Security.IntegrationTests.Rcm.AspNetCore5AsmDataSecurityEnabledBlockingRequestIpOneClick - Last Failure

    Expand for error 
     Results do not match.
 Differences:
 Received: Security.AspNetCore5AsmDataSecurityEnabled.__test=blocking-ips-oneclick_url=_.received.txt
 Verified: Security.AspNetCore5AsmDataSecurityEnabled.__test=blocking-ips-oneclick_url=_.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: aspnet_core.request,
 ...

⌛ Performance Regressions vs Default Branch (1)

  • StartStopWithChild - Benchmarks.Trace.ActivityBenchmark 19.21µs (+3.22µs, +20%) - Details

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6052) - mean (70ms)  : 67, 72
     .   : milestone, 70,
    master - mean (70ms)  : 67, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6052) - mean (1,107ms)  : 1081, 1133
     .   : milestone, 1107,
    master - mean (1,106ms)  : 1075, 1137
     .   : milestone, 1106,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6052) - mean (108ms)  : 105, 111
     .   : milestone, 108,
    master - mean (109ms)  : 105, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6052) - mean (799ms)  : 775, 822
     .   : milestone, 799,
    master - mean (801ms)  : 783, 820
     .   : milestone, 801,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6052) - mean (93ms)  : 89, 97
     .   : milestone, 93,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6052) - mean (751ms)  : 730, 772
     .   : milestone, 751,
    master - mean (746ms)  : 724, 768
     .   : milestone, 746,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6052) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (191ms)  : 187, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6052) - mean (1,196ms)  : 1170, 1223
     .   : milestone, 1196,
    master - mean (1,192ms)  : 1167, 1217
     .   : milestone, 1192,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6052) - mean (277ms)  : 274, 281
     .   : milestone, 277,
    master - mean (278ms)  : 274, 282
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6052) - mean (965ms)  : 941, 989
     .   : milestone, 965,
    master - mean (963ms)  : 942, 984
     .   : milestone, 963,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6052) - mean (265ms)  : 261, 269
     .   : milestone, 265,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6052) - mean (941ms)  : 919, 963
     .   : milestone, 941,
    master - mean (944ms)  : 916, 972
     .   : milestone, 944,
Loading

duncanista added a commit that referenced this pull request Sep 18, 2024
@duncanista
[backport][serverless] trigger consolidated pipeline on tags (#6052 =…
f11b280 
…> v2) (#6053)

## Summary of changes

Removes exclusion of pipeline trigger for tags.

## Reason for change

Serverless requires a build on a tag in order to have a production ready
pipeline to use.

## Implementation details

n/a

## Test coverage

## Other details
<!-- Fixes #{issue} -->

<!-- ⚠️ Note: where possible, please obtain 2 approvals prior to
merging. Unless CODEOWNERS specifies otherwise, for external teams it is
typically best to have one review from a team member, and one review
from apm-dotnet. Trivial changes do not require 2 reviews. -->
@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6052 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.129
  • 2 benchmarks are slower, with geometric mean 1.161
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6052

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 1.176 16,405.22 19,287.01

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.68μs 43.5ns 292ns 0.0117 0.00389 0 5.43 KB
master StartStopWithChild netcoreapp3.1 10.1μs 56.5ns 357ns 0.0215 0.00539 0 5.61 KB
master StartStopWithChild net472 16.4μs 39.7ns 154ns 1.01 0.299 0.0889 6.05 KB
#6052 StartStopWithChild net6.0 7.5μs 41.2ns 247ns 0.0155 0.00775 0 5.42 KB
#6052 StartStopWithChild netcoreapp3.1 10μs 51.7ns 297ns 0.0242 0.0145 0.00485 5.62 KB
#6052 StartStopWithChild net472 19.2μs 76.1ns 295ns 0.996 0.276 0.069 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 474μs 188ns 704ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 644μs 305ns 1.14μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 837μs 520ns 2.01μs 0.417 0 0 3.3 KB
#6052 WriteAndFlushEnrichedTraces net6.0 472μs 280ns 1.01μs 0 0 0 2.7 KB
#6052 WriteAndFlushEnrichedTraces netcoreapp3.1 627μs 216ns 780ns 0 0 0 2.7 KB
#6052 WriteAndFlushEnrichedTraces net472 850μs 521ns 2.02μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 196μs 1.1μs 8.57μs 0.187 0 0 18.45 KB
master SendRequest netcoreapp3.1 221μs 1.27μs 10.1μs 0.216 0 0 20.61 KB
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#6052 SendRequest net6.0 200μs 1.12μs 7.4μs 0.201 0 0 18.45 KB
#6052 SendRequest netcoreapp3.1 221μs 1.25μs 8.85μs 0.213 0 0 20.61 KB
#6052 SendRequest net472 1.23E‑06ns 1.23E‑06ns 4.61E‑06ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 567μs 2.98μs 14.3μs 0.553 0 0 41.82 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 666μs 2.5μs 9.34μs 0.334 0 0 41.73 KB
master WriteAndFlushEnrichedTraces net472 877μs 3.33μs 12.5μs 8.19 2.59 0.431 53.31 KB
#6052 WriteAndFlushEnrichedTraces net6.0 570μs 3.03μs 16.3μs 0.561 0 0 41.64 KB
#6052 WriteAndFlushEnrichedTraces netcoreapp3.1 669μs 2.16μs 8.09μs 0.353 0 0 41.88 KB
#6052 WriteAndFlushEnrichedTraces net472 842μs 3.82μs 14.8μs 8.12 2.44 0.406 53.27 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.31μs 1.3ns 5.05ns 0.0145 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.77μs 2.3ns 8.92ns 0.0133 0 0 1.02 KB
master ExecuteNonQuery net472 2.15μs 2.63ns 10.2ns 0.156 0 0 987 B
#6052 ExecuteNonQuery net6.0 1.2μs 0.914ns 3.54ns 0.0143 0 0 1.02 KB
#6052 ExecuteNonQuery netcoreapp3.1 1.77μs 1.98ns 7.43ns 0.0139 0 0 1.02 KB
#6052 ExecuteNonQuery net472 2.04μs 1.75ns 6.54ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.21μs 1.1ns 4.25ns 0.0133 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.48μs 0.908ns 3.52ns 0.0133 0 0 976 B
master CallElasticsearch net472 2.66μs 7.72ns 29.9ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.33μs 1.37ns 4.92ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.6μs 1.56ns 5.85ns 0.0136 0 0 1.02 KB
master CallElasticsearchAsync net472 2.7μs 7.04ns 27.3ns 0.167 0 0 1.05 KB
#6052 CallElasticsearch net6.0 1.31μs 1.19ns 4.45ns 0.0137 0 0 976 B
#6052 CallElasticsearch netcoreapp3.1 1.54μs 0.832ns 3.22ns 0.0132 0 0 976 B
#6052 CallElasticsearch net472 2.68μs 1.31ns 5.06ns 0.158 0 0 995 B
#6052 CallElasticsearchAsync net6.0 1.28μs 0.558ns 2.16ns 0.0135 0 0 952 B
#6052 CallElasticsearchAsync netcoreapp3.1 1.66μs 2.45ns 9.49ns 0.0141 0 0 1.02 KB
#6052 CallElasticsearchAsync net472 2.68μs 2.04ns 7.91ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6052

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 1.146 1,534.40 1,758.03

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.31μs 0.932ns 3.61ns 0.0135 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.53μs 0.602ns 2.25ns 0.0133 0 0 952 B
master ExecuteAsync net472 1.83μs 0.725ns 2.81ns 0.145 0 0 915 B
#6052 ExecuteAsync net6.0 1.19μs 0.557ns 2.16ns 0.0134 0 0 952 B
#6052 ExecuteAsync netcoreapp3.1 1.76μs 4.25ns 16.5ns 0.0122 0 0 952 B
#6052 ExecuteAsync net472 1.76μs 0.848ns 3.17ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.27μs 1.28ns 4.62ns 0.0298 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.07μs 2.45ns 9.5ns 0.0355 0 0 2.76 KB
master SendAsync net472 7.67μs 1.8ns 6.97ns 0.5 0 0 3.15 KB
#6052 SendAsync net6.0 4.13μs 2.23ns 8.35ns 0.0311 0 0 2.22 KB
#6052 SendAsync netcoreapp3.1 5.21μs 2.12ns 7.65ns 0.0366 0 0 2.76 KB
#6052 SendAsync net472 7.73μs 3.3ns 12.3ns 0.499 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.5μs 1.86ns 6.97ns 0.0232 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.18μs 0.845ns 3.16ns 0.0218 0 0 1.64 KB
master EnrichedLog net472 2.59μs 1.85ns 7.18ns 0.25 0 0 1.57 KB
#6052 EnrichedLog net6.0 1.49μs 1.11ns 4.3ns 0.0231 0 0 1.64 KB
#6052 EnrichedLog netcoreapp3.1 2.15μs 0.728ns 2.52ns 0.0226 0 0 1.64 KB
#6052 EnrichedLog net472 2.59μs 1.1ns 4.24ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 108ns 403ns 0.0566 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 232ns 897ns 0 0 0 4.28 KB
master EnrichedLog net472 146μs 103ns 398ns 0.659 0.22 0 4.46 KB
#6052 EnrichedLog net6.0 114μs 114ns 441ns 0 0 0 4.28 KB
#6052 EnrichedLog netcoreapp3.1 119μs 191ns 690ns 0.0595 0 0 4.28 KB
#6052 EnrichedLog net472 146μs 90.7ns 351ns 0.655 0.218 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.91μs 1.01ns 3.77ns 0.0306 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.33μs 1.1ns 4.11ns 0.0282 0 0 2.2 KB
master EnrichedLog net472 5.14μs 2.54ns 9.82ns 0.319 0 0 2.02 KB
#6052 EnrichedLog net6.0 3.11μs 4.18ns 16.2ns 0.031 0 0 2.2 KB
#6052 EnrichedLog netcoreapp3.1 4.25μs 1.27ns 4.76ns 0.0297 0 0 2.2 KB
#6052 EnrichedLog net472 4.79μs 1.09ns 4.22ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.38μs 0.585ns 2.26ns 0.0159 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.73μs 1.97ns 7.62ns 0.0156 0 0 1.14 KB
master SendReceive net472 1.96μs 0.852ns 3.3ns 0.183 0.000981 0 1.16 KB
#6052 SendReceive net6.0 1.36μs 0.3ns 1.12ns 0.0163 0 0 1.14 KB
#6052 SendReceive netcoreapp3.1 1.7μs 1.08ns 4.03ns 0.0154 0 0 1.14 KB
#6052 SendReceive net472 2.03μs 0.486ns 1.82ns 0.183 0.00102 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.78μs 0.945ns 3.54ns 0.0223 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.84μs 1.81ns 6.77ns 0.0229 0 0 1.65 KB
master EnrichedLog net472 4.37μs 1.79ns 6.92ns 0.323 0 0 2.04 KB
#6052 EnrichedLog net6.0 2.83μs 1.02ns 3.82ns 0.0226 0 0 1.6 KB
#6052 EnrichedLog netcoreapp3.1 3.95μs 1.6ns 6.2ns 0.0218 0 0 1.65 KB
#6052 EnrichedLog net472 4.4μs 2ns 7.75ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 399ns 0.129ns 0.499ns 0.00816 0 0 576 B
master StartFinishSpan netcoreapp3.1 568ns 3.15ns 20.2ns 0.0078 0 0 576 B
master StartFinishSpan net472 670ns 2.34ns 8.77ns 0.0915 0 0 578 B
master StartFinishScope net6.0 482ns 0.23ns 0.861ns 0.0097 0 0 696 B
master StartFinishScope netcoreapp3.1 722ns 0.692ns 2.68ns 0.00944 0 0 696 B
master StartFinishScope net472 845ns 0.592ns 2.29ns 0.105 0 0 658 B
#6052 StartFinishSpan net6.0 399ns 0.847ns 3.28ns 0.00815 0 0 576 B
#6052 StartFinishSpan netcoreapp3.1 555ns 0.248ns 0.93ns 0.00802 0 0 576 B
#6052 StartFinishSpan net472 667ns 3.32ns 14.5ns 0.0915 0 0 578 B
#6052 StartFinishScope net6.0 480ns 0.157ns 0.566ns 0.00978 0 0 696 B
#6052 StartFinishScope netcoreapp3.1 726ns 0.34ns 1.32ns 0.00946 0 0 696 B
#6052 StartFinishScope net472 932ns 1.4ns 5.06ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6052

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.129 681.97 604.20

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 682ns 0.353ns 1.37ns 0.00982 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 964ns 1.65ns 6.4ns 0.00957 0 0 696 B
master RunOnMethodBegin net472 1.14μs 4.41ns 17.1ns 0.104 0 0 658 B
#6052 RunOnMethodBegin net6.0 606ns 1.12ns 4.19ns 0.00997 0 0 696 B
#6052 RunOnMethodBegin netcoreapp3.1 877ns 0.273ns 0.946ns 0.00953 0 0 696 B
#6052 RunOnMethodBegin net472 1.05μs 0.373ns 1.44ns 0.104 0 0 658 B

@andrewlock
Copy link
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6052) (11.122M)   : 0, 11122047
    master (11.241M)   : 0, 11241347
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6052) (7.354M)   : 0, 7353959
    master (7.436M)   : 0, 7436259
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.624M)   : 0, 7623650

    section Manual
    master (11.144M)   : 0, 11143937

    section Manual + Automatic
    This PR (6052) (6.798M)   : 0, 6798382
    master (6.769M)   : 0, 6769336

    section DD_TRACE_ENABLED=0
    master (10.231M)   : 0, 10230944
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6052) (9.593M)   : 0, 9593148
    master (9.526M)   : 0, 9525943
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6052) (6.432M)   : 0, 6432447
    master (6.610M)   : 0, 6610089

    section Trace stats
    master (6.947M)   : 0, 6947051

    section Manual
    master (9.627M)   : 0, 9627325

    section Manual + Automatic
    This PR (6052) (5.955M)   : 0, 5954989
    master (6.082M)   : 0, 6081694

    section DD_TRACE_ENABLED=0
    master (8.789M)   : 0, 8789404
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6052) (9.930M)   : 0, 9930204
    master (10.078M)   : 0, 10077851
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6052) (6.705M)   : 0, 6705259
    master (6.777M)   : 0, 6777224
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.294M)   : 0, 7293536

    section Manual
    master (9.738M)   : 0, 9737534

    section Manual + Automatic
    This PR (6052) (6.162M)   : 0, 6162118
    master (6.208M)   : 0, 6208249

    section DD_TRACE_ENABLED=0
    master (9.212M)   : 0, 9211944
Loading

@duncanista duncanista merged commit 34f45e7 into master Sep 18, 2024
71 of 73 checks passed
@duncanista duncanista deleted the jordan.gonzalez/trigger-pipeline-on-tags branch September 18, 2024 16:43
@github-actions github-actions bot added this to the vNext-v3 milestone Sep 18, 2024
@andrewlock andrewlock mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages area:serverless
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@duncanista @andrewlock