Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dani/testvis/impacted tests poc rebase #6559

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

daniel-romano-DD
Copy link
Contributor

@daniel-romano-DD daniel-romano-DD commented Jan 15, 2025

Summary of changes

Implementer Milestones 1.0 and 1.5 of Impacted Tests Detection RFC

Reason for change

Detecting which tests have changed in a commit and mark them will enable future actions over them, like launching Early Flake Detection

Implementation details

Milestone 1.5 requires having access to Git CLI, and being in a PR. Retrieves changed files and lines by Git Diff from base commit and intersects them with the test definition file. If collision is detected, the test is marked as modified.

Test coverage

Added unit and integration tests.
Integration tests relies on two predefined commits with known changes to certain tests, which get checked for the is_modifed tag in a verify snapshot.

Notes

Superseeding #6366 because of heavy rebase conflicts

@andrewlock
Copy link
Member

andrewlock commented Jan 15, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6559) - mean (69ms)  : 65, 74
     .   : milestone, 69,
    master - mean (69ms)  : 67, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6559) - mean (981ms)  : 956, 1006
     .   : milestone, 981,
    master - mean (983ms)  : 962, 1005
     .   : milestone, 983,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6559) - mean (108ms)  : 105, 110
     .   : milestone, 108,
    master - mean (108ms)  : 105, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6559) - mean (675ms)  : 662, 688
     .   : milestone, 675,
    master - mean (679ms)  : 661, 698
     .   : milestone, 679,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6559) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 92
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6559) - mean (634ms)  : 616, 651
     .   : milestone, 634,
    master - mean (633ms)  : 618, 649
     .   : milestone, 633,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6559) - mean (191ms)  : 187, 196
     .   : milestone, 191,
    master - mean (191ms)  : 186, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6559) - mean (1,097ms)  : 1070, 1124
     .   : milestone, 1097,
    master - mean (1,090ms)  : 1064, 1116
     .   : milestone, 1090,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6559) - mean (277ms)  : 272, 281
     .   : milestone, 277,
    master - mean (276ms)  : 271, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6559) - mean (864ms)  : 841, 888
     .   : milestone, 864,
    master - mean (867ms)  : 837, 897
     .   : milestone, 867,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6559) - mean (265ms)  : 260, 269
     .   : milestone, 265,
    master - mean (264ms)  : 261, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6559) - mean (850ms)  : 817, 883
     .   : milestone, 850,
    master - mean (849ms)  : 821, 877
     .   : milestone, 849,

Loading

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 15, 2025

Datadog Report

Branch report: dani/testvis/impacted_tests_poc_rebase
Commit report: 78f649d
Test service: dd-trace-dotnet

✅ 0 Failed, 239883 Passed, 2069 Skipped, 18h 48m 36.01s Total Time

@andrewlock
Copy link
Member

andrewlock commented Jan 17, 2025

Benchmarks Report for tracer 🐌

Benchmarks for #6559 compared to master:

  • 4 benchmarks are faster, with geometric mean 1.176
  • 2 benchmarks are slower, with geometric mean 1.125
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.04μs 45.5ns 302ns 0.0156 0.00779 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.4μs 58.4ns 374ns 0.0201 0.0101 0 5.8 KB
master StartStopWithChild net472 16.5μs 48.9ns 183ns 1.04 0.317 0.0976 6.2 KB
#6559 StartStopWithChild net6.0 7.95μs 43.2ns 259ns 0.0253 0.0127 0 5.61 KB
#6559 StartStopWithChild netcoreapp3.1 9.97μs 54.2ns 330ns 0.0199 0.00498 0 5.8 KB
#6559 StartStopWithChild net472 16.5μs 63.6ns 246ns 1.04 0.294 0.0982 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 467μs 545ns 2.04μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 446ns 1.67μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 870μs 562ns 2.1μs 0.431 0 0 3.3 KB
#6559 WriteAndFlushEnrichedTraces net6.0 472μs 396ns 1.53μs 0 0 0 2.7 KB
#6559 WriteAndFlushEnrichedTraces netcoreapp3.1 640μs 571ns 2.14μs 0 0 0 2.7 KB
#6559 WriteAndFlushEnrichedTraces net472 846μs 463ns 1.67μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6559

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑net6.0 1.214 154,605.39 127,373.03
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑netcoreapp3.1 1.206 175,264.31 145,308.18

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 156μs 916ns 8.44μs 0.155 0 0 14.47 KB
master SendRequest netcoreapp3.1 177μs 1.04μs 10.2μs 0.167 0 0 17.27 KB
master SendRequest net472 0.00254ns 0.00122ns 0.00456ns 0 0 0 0 b
#6559 SendRequest net6.0 127μs 522ns 1.95μs 0.192 0 0 14.47 KB
#6559 SendRequest netcoreapp3.1 145μs 439ns 1.7μs 0.214 0 0 17.27 KB
#6559 SendRequest net472 0.021ns 0.00273ns 0.0106ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 564μs 2.9μs 15.4μs 0.553 0 0 41.68 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 663μs 3.41μs 16.7μs 0.329 0 0 41.74 KB
master WriteAndFlushEnrichedTraces net472 878μs 4.09μs 15.3μs 8.13 2.57 0.428 53.3 KB
#6559 WriteAndFlushEnrichedTraces net6.0 587μs 3.3μs 21.9μs 0.563 0 0 41.69 KB
#6559 WriteAndFlushEnrichedTraces netcoreapp3.1 672μs 3.8μs 25.8μs 0.342 0 0 41.72 KB
#6559 WriteAndFlushEnrichedTraces net472 868μs 4.34μs 19.9μs 8.39 2.52 0.419 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.36μs 1.28ns 4.77ns 0.0144 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.76μs 1.86ns 7.21ns 0.0132 0 0 1.02 KB
master ExecuteNonQuery net472 2.08μs 1.31ns 4.71ns 0.156 0.00103 0 987 B
#6559 ExecuteNonQuery net6.0 1.3μs 1.31ns 4.89ns 0.0143 0 0 1.02 KB
#6559 ExecuteNonQuery netcoreapp3.1 1.71μs 1.54ns 5.98ns 0.0138 0 0 1.02 KB
#6559 ExecuteNonQuery net472 2.14μs 2.09ns 7.83ns 0.156 0.00107 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.27μs 0.805ns 3.12ns 0.014 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.59μs 0.695ns 2.6ns 0.0127 0 0 976 B
master CallElasticsearch net472 2.58μs 1.69ns 6.53ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.36μs 3.65ns 13.7ns 0.013 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.61μs 0.572ns 1.98ns 0.0132 0 0 1.02 KB
master CallElasticsearchAsync net472 2.69μs 1.01ns 3.77ns 0.167 0 0 1.05 KB
#6559 CallElasticsearch net6.0 1.18μs 0.367ns 1.37ns 0.014 0 0 976 B
#6559 CallElasticsearch netcoreapp3.1 1.66μs 2.14ns 8ns 0.0131 0 0 976 B
#6559 CallElasticsearch net472 2.6μs 2.22ns 8.58ns 0.157 0 0 995 B
#6559 CallElasticsearchAsync net6.0 1.24μs 1.31ns 5.08ns 0.0131 0 0 952 B
#6559 CallElasticsearchAsync netcoreapp3.1 1.6μs 0.426ns 1.54ns 0.0141 0 0 1.02 KB
#6559 CallElasticsearchAsync net472 2.69μs 1.14ns 4.27ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.26μs 1.49ns 5.78ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.61μs 1.32ns 4.93ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.85μs 0.501ns 1.94ns 0.145 0 0 915 B
#6559 ExecuteAsync net6.0 1.21μs 0.368ns 1.43ns 0.0135 0 0 952 B
#6559 ExecuteAsync netcoreapp3.1 1.63μs 0.966ns 3.48ns 0.0132 0 0 952 B
#6559 ExecuteAsync net472 1.78μs 0.642ns 2.49ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.26μs 2.21ns 7.96ns 0.0323 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.33μs 1.96ns 7.6ns 0.0375 0 0 2.85 KB
master SendAsync net472 7.47μs 2.2ns 8.54ns 0.496 0 0 3.12 KB
#6559 SendAsync net6.0 4.39μs 2.61ns 10.1ns 0.0329 0 0 2.31 KB
#6559 SendAsync netcoreapp3.1 5.48μs 2.16ns 8.36ns 0.0355 0 0 2.85 KB
#6559 SendAsync net472 7.54μs 1.17ns 4.38ns 0.494 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.54μs 1.02ns 3.82ns 0.0225 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.19μs 0.782ns 2.82ns 0.022 0 0 1.64 KB
master EnrichedLog net472 2.76μs 1.65ns 6.39ns 0.249 0 0 1.57 KB
#6559 EnrichedLog net6.0 1.52μs 0.546ns 2.04ns 0.0228 0 0 1.64 KB
#6559 EnrichedLog netcoreapp3.1 2.16μs 0.656ns 2.37ns 0.0216 0 0 1.64 KB
#6559 EnrichedLog net472 2.62μs 0.716ns 2.68ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 118μs 246ns 953ns 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 121μs 170ns 657ns 0.0598 0 0 4.28 KB
master EnrichedLog net472 152μs 270ns 1.05μs 0.678 0.226 0 4.46 KB
#6559 EnrichedLog net6.0 116μs 116ns 449ns 0.0577 0 0 4.28 KB
#6559 EnrichedLog netcoreapp3.1 120μs 158ns 612ns 0.0598 0 0 4.28 KB
#6559 EnrichedLog net472 150μs 114ns 442ns 0.674 0.225 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.92μs 1.15ns 4.44ns 0.0307 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.23μs 1.56ns 6.03ns 0.0295 0 0 2.2 KB
master EnrichedLog net472 4.96μs 1.61ns 6.24ns 0.32 0 0 2.02 KB
#6559 EnrichedLog net6.0 3.09μs 2.83ns 10.9ns 0.0311 0 0 2.2 KB
#6559 EnrichedLog netcoreapp3.1 4.29μs 2.01ns 7.79ns 0.0299 0 0 2.2 KB
#6559 EnrichedLog net472 4.87μs 1.28ns 4.79ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.39μs 0.46ns 1.66ns 0.0159 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.78μs 2.29ns 8.89ns 0.0151 0 0 1.14 KB
master SendReceive net472 2.03μs 0.605ns 2.26ns 0.183 0 0 1.16 KB
#6559 SendReceive net6.0 1.38μs 0.463ns 1.73ns 0.0158 0 0 1.14 KB
#6559 SendReceive netcoreapp3.1 1.82μs 0.765ns 2.96ns 0.0155 0 0 1.14 KB
#6559 SendReceive net472 2.15μs 0.594ns 2.22ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.72μs 1.18ns 4.58ns 0.0231 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.96μs 4.2ns 15.7ns 0.0216 0 0 1.65 KB
master EnrichedLog net472 4.51μs 2.54ns 9.82ns 0.323 0 0 2.04 KB
#6559 EnrichedLog net6.0 2.75μs 0.697ns 2.61ns 0.022 0 0 1.6 KB
#6559 EnrichedLog netcoreapp3.1 3.92μs 1.89ns 7.08ns 0.0216 0 0 1.65 KB
#6559 EnrichedLog net472 4.49μs 2.69ns 10.4ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6559

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.137 507.62 577.04
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 1.114 881.30 982.00

Faster 🎉 in #6559

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.157 623.54 538.82
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.128 453.35 401.91

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 453ns 0.134ns 0.502ns 0.00816 0 0 576 B
master StartFinishSpan netcoreapp3.1 624ns 0.546ns 2.12ns 0.00781 0 0 576 B
master StartFinishSpan net472 709ns 0.439ns 1.7ns 0.0917 0 0 578 B
master StartFinishScope net6.0 507ns 0.345ns 1.34ns 0.00963 0 0 696 B
master StartFinishScope netcoreapp3.1 751ns 0.667ns 2.58ns 0.00937 0 0 696 B
master StartFinishScope net472 882ns 0.492ns 1.91ns 0.104 0 0 658 B
#6559 StartFinishSpan net6.0 402ns 0.194ns 0.752ns 0.00807 0 0 576 B
#6559 StartFinishSpan netcoreapp3.1 539ns 0.429ns 1.61ns 0.00758 0 0 576 B
#6559 StartFinishSpan net472 758ns 0.574ns 2.22ns 0.0915 0 0 578 B
#6559 StartFinishScope net6.0 577ns 0.561ns 2.17ns 0.00985 0 0 696 B
#6559 StartFinishScope netcoreapp3.1 734ns 2.48ns 9.62ns 0.00927 0 0 696 B
#6559 StartFinishScope net472 982ns 1.05ns 4.08ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 635ns 0.375ns 1.4ns 0.00991 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 911ns 0.511ns 1.98ns 0.0092 0 0 696 B
master RunOnMethodBegin net472 1.19μs 0.399ns 1.55ns 0.104 0 0 658 B
#6559 RunOnMethodBegin net6.0 606ns 0.292ns 1.13ns 0.00996 0 0 696 B
#6559 RunOnMethodBegin netcoreapp3.1 906ns 0.854ns 3.31ns 0.00962 0 0 696 B
#6559 RunOnMethodBegin net472 1.15μs 0.999ns 3.87ns 0.104 0 0 658 B

tracer/src/Datadog.Trace/Ci/GitCommandHelper.cs Outdated Show resolved Hide resolved
tracer/src/Datadog.Trace/Ci/GitCommandHelper.cs Outdated Show resolved Hide resolved
tracer/src/Datadog.Trace/Ci/ImpactedTestsModule.cs Outdated Show resolved Hide resolved
tracer/src/Datadog.Trace/Ci/ImpactedTestsModule.cs Outdated Show resolved Hide resolved
tracer/src/Datadog.Trace/Ci/ImpactedTestsModule.cs Outdated Show resolved Hide resolved
tracer/src/Datadog.Trace/Ci/ImpactedTestsModule.cs Outdated Show resolved Hide resolved
tracer/src/Datadog.Trace/Ci/ImpactedTestsModule.cs Outdated Show resolved Hide resolved
@@ -32,6 +32,7 @@ public void SimpleErrorTest()
{
_output.WriteLine("Test:SimpleErrorTest");
int i = 0;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this?

Comment on lines 66 to 67


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this?

@daniel-romano-DD daniel-romano-DD force-pushed the dani/testvis/impacted_tests_poc_rebase branch from 8e92019 to 7590886 Compare January 17, 2025 12:03
WIP

FileBitmap tests added

Get modified lines from git diff

Added metrics

Record telemetry event

Integration tests

Fixed relative paths

Fixed range

Fix error

Modified test files for testing purpose

Added working integration test

Git command helper

Trimming file fix

Fixed telemetry intake

Added missing metric in json

Restored test files

Milestone 1.0 support

Rebase fix

Fixed tests

FileBitmap suggestions

PR comments

Updated metrics

Better traces

Limit test to windows because 'git branch --get-current' returns empty due to a possible detached head status on linux

Fixed tests in linux

Updated testing commit shas

Debug test in linux

Improved git command traces

Added git availability checks

Fixed ammend command
Fixed tests shas

PR comments

Removed double summary

Update tracer/src/Datadog.Trace/Ci/ImpactedTestsModule.cs

Co-authored-by: Tony Redondo <[email protected]>

Update tracer/src/Datadog.Trace/Ci/ImpactedTestsModule.cs

Co-authored-by: Tony Redondo <[email protected]>

Update tracer/src/Datadog.Trace/Ci/GitCommandHelper.cs

Co-authored-by: Tony Redondo <[email protected]>

PR comments

Made tests work over head

PR Comment

Enabled debug traces

Alpine test fix
@daniel-romano-DD daniel-romano-DD force-pushed the dani/testvis/impacted_tests_poc_rebase branch from c2b3ff0 to 6562afd Compare January 17, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants