-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Reduce AMQP & PCNTL Tests flakiness #3043
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3043 +/- ##
============================================
- Coverage 74.80% 74.78% -0.02%
Complexity 2784 2784
============================================
Files 112 112
Lines 11020 11020
============================================
- Hits 8243 8241 -2
- Misses 2777 2779 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, thank you!
055b40c
to
2948eb7
Compare
LGTM, but to make it a bit less intrusive, you could implement it with an annotation on the test, for example using https://gist.github.com/makasim/989fcaa6da8ff579f7914d973e68280c or https://github.com/bshaffer/phpunit-retry-annotations |
Hmmm, it's still failing (example) despite retries... I'll put this back to draft and may investigate further later on. PS: Note that this still helps with flakiness (amqp example) |
Description
I was getting a bit bored of these tests failing here and there in CI jobs... I believe this quick workaround could help us trust the CI a bit more.
The workaround simply consist in retrying the tests, up to five times.
This only affects
integration_snapshots-test_integrations
Reviewer checklist