Fall back to stderr if the log path contains colons #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Weinand <[email protected]>
bwoebi
force-pushed
the
bob/fix_serverless
branch
from
534ac0a to
5242865
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3044 +/- ##
============================================
+ Coverage 72.93% 74.80% +1.86%
Complexity 2781 2781
============================================
Files 139 112 -27
Lines 15166 11017 -4149
Branches 1022 0 -1022
============================================
- Hits 11062 8241 -2821
+ Misses 3552 2776 -776
+ Partials 552 0 -552
Flags with carried forward coverage won't be shown. Click here to find out more. see 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
realFlowControl
pushed a commit
that referenced
this pull request
Jan 17, 2025
Signed-off-by: Bob Weinand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mitigates issues with logging being to special devices / pipes.