-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pin): deprecates multi tracer support in ddtrace.Pin [3.0] #11884
chore(pin): deprecates multi tracer support in ddtrace.Pin [3.0] #11884
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 322 Passed, 1276 Skipped, 5m 57.9s Total duration (34m 28.43s time saved) |
BenchmarksBenchmark execution time: 2025-01-16 22:26:05 Comparing candidate commit 1973fb6 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 208 metrics, 2 unstable metrics. |
releasenotes/notes/remove-multi-tracer-support-from-pin-f2f20ca3fa731929.yaml
Show resolved
Hide resolved
3174831
to
911bd62
Compare
Motivation
In ddtrace v3.0 ddtrace will drop support for initializing multiple instance of
ddtrace.Tracer
. With this change the all pin objects will use the same tracer instance. There is no need to support initializing, cloning or overriding the Pin.tracer property.Changes
Pin.override(..)
,Pin.__init__(...)
, andPin.clone(...)
TODO: deprecate and eventually remove Pin.tracer property. The global tracer should always be referenced.
Checklist
Reviewer Checklist