Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): taint get and post http parameter name in django #11945

Merged

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Jan 15, 2025

Code security: Django request args and form were not tainted properly (they were overwritten).

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

CODEOWNERS have been resolved as:

ddtrace/appsec/_iast/_handlers.py                                       @DataDog/asm-python
tests/contrib/django/django_app/appsec_urls.py                          @DataDog/asm-python
tests/contrib/django/test_django_appsec_iast.py                         @DataDog/asm-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: gnufede/APPSEC-56294-taint-django-http-request-parameter-name
Commit report: 25db243
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 54.63s Total duration (29m 19.02s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2025

Benchmarks

Benchmark execution time: 2025-01-16 10:32:23

Comparing candidate commit 60ece88 in PR branch gnufede/APPSEC-56294-taint-django-http-request-parameter-name with baseline commit b13bcb0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@gnufede gnufede marked this pull request as ready for review January 15, 2025 11:22
@gnufede gnufede requested a review from a team as a code owner January 15, 2025 11:22
improve tests

fix test

fix test

fix test

fix test

fix test

fix test
@gnufede gnufede enabled auto-merge (squash) January 16, 2025 09:51
@gnufede gnufede merged commit 4183671 into main Jan 16, 2025
317 of 318 checks passed
@gnufede gnufede deleted the gnufede/APPSEC-56294-taint-django-http-request-parameter-name branch January 16, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants