Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tracing): deprecates FilterRequestsOnUrl [3.0] #11962

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 15, 2025

In recent ddtrace versions spans can be sampled by tags and resource names via the DD_TRACE_SAMPLING_RULES configuration. Setting this configuration allows ddtrace to compute accurate trace metrics and prevents the generation of partial traces.

To encourage the use of DD_TRACE_SAMPLING_RULES, FilterRequestsOnUrl will be deprecated.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur requested review from a team as code owners January 15, 2025 18:09
Copy link
Contributor

github-actions bot commented Jan 15, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/ddtrace-resourcefilter-deprecated-52b1c92d388b0518.yaml  @DataDog/apm-python
ddtrace/contrib/tornado/__init__.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/filters.py                                                      @DataDog/apm-sdk-api-python
ddtrace/trace/__init__.py                                               @DataDog/apm-core-python
docs/advanced_usage.rst                                                 @DataDog/python-guild
tests/tracer/test_filters.py                                            @DataDog/apm-sdk-api-python

@mabdinur mabdinur force-pushed the munir/remove-customer-filter-from-trace-api branch from d6f0509 to 837afa9 Compare January 15, 2025 18:10
@mabdinur mabdinur requested a review from a team as a code owner January 15, 2025 18:10
@mabdinur mabdinur changed the title chore(tracing): deprecates FilterRequestsOnUrl chore(tracing): deprecates FilterRequestsOnUrl [3.0] Jan 15, 2025
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 15, 2025

Datadog Report

Branch report: munir/remove-customer-filter-from-trace-api
Commit report: 00c9d74
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 33.51s Total duration (35m 25.82s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2025

Benchmarks

Benchmark execution time: 2025-01-16 19:35:40

Comparing candidate commit 00c9d74 in PR branch munir/remove-customer-filter-from-trace-api with baseline commit b028cc6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@mabdinur mabdinur requested a review from ZStriker19 January 16, 2025 16:33
@mabdinur mabdinur force-pushed the munir/remove-customer-filter-from-trace-api branch from 85f9db0 to 59032ba Compare January 16, 2025 17:57
@mabdinur mabdinur force-pushed the munir/remove-customer-filter-from-trace-api branch from 59032ba to bc8efa5 Compare January 16, 2025 17:59
@mabdinur mabdinur enabled auto-merge (squash) January 16, 2025 18:55
@mabdinur mabdinur merged commit 0275a5e into main Jan 16, 2025
650 of 651 checks passed
@mabdinur mabdinur deleted the munir/remove-customer-filter-from-trace-api branch January 16, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants