Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce APM_TRACING RC product #11980

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

P403n1x87
Copy link
Contributor

We introduce the APM_TRACING remote configuration product that allows dispatching remote configuration to the library for remote enablement/ configuration of library components and features.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 16, 2025
@P403n1x87 P403n1x87 self-assigned this Jan 16, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/internal/remoteconfig/products/__init__.py                      @DataDog/remote-config @DataDog/apm-core-python
ddtrace/internal/remoteconfig/products/apm_tracing.py                   @DataDog/remote-config @DataDog/apm-core-python
ddtrace/settings/remoteconfig.py                                        @DataDog/apm-core-python
ddtrace/debugging/_debugger.py                                          @DataDog/debugger-python
ddtrace/debugging/_products/dynamic_instrumentation.py                  @DataDog/debugger-python
pyproject.toml                                                          @DataDog/python-guild
ddtrace/internal/remoteconfig/products/client.py                        @DataDog/remote-config @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 16, 2025

Datadog Report

Branch report: chore/apm-tracing-rc
Commit report: 13eabbc
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 5m 1.69s Total duration (35m 34.51s time saved)

We introduce the APM_TRACING remote configuration product that allows
dispatching remote configuration to the library for remote enablement/
configuration of library components and features.
@P403n1x87 P403n1x87 force-pushed the chore/apm-tracing-rc branch from 6367ef6 to 13eabbc Compare January 16, 2025 11:33
@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2025

Benchmarks

Benchmark execution time: 2025-01-16 12:14:05

Comparing candidate commit 13eabbc in PR branch chore/apm-tracing-rc with baseline commit 4183671 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant