Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(appsec): connect testagent service to tests #11985

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Jan 16, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

CODEOWNERS have been resolved as:

hatch.toml                                                              @DataDog/python-guild
scripts/gen_gitlab_config.py                                            @DataDog/apm-core-python
tests/appsec/integrations/flask_tests/test_flask_remoteconfig.py        @DataDog/asm-python
tests/appsec/suitespec.yml                                              @DataDog/asm-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 16, 2025

Datadog Report

Branch report: avara1985/test_agent_gitlab
Commit report: c807ecd
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 16.01s Total duration (35m 23.24s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2025

Benchmarks

Benchmark execution time: 2025-01-17 16:40:24

Comparing candidate commit c807ecd in PR branch avara1985/test_agent_gitlab with baseline commit 400053f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

Base automatically changed from avara1986/APPSEC-56157-migrate_iast_django to main January 17, 2025 10:57
@avara1986 avara1986 marked this pull request as ready for review January 17, 2025 14:52
@avara1986 avara1986 requested review from a team as code owners January 17, 2025 14:52
@avara1986 avara1986 changed the title chore: connect to testagent chore(appsec): connect to testagent Jan 17, 2025
@avara1986 avara1986 changed the title chore(appsec): connect to testagent ci(appsec): connect testsuit to testagent services Jan 17, 2025
@avara1986 avara1986 changed the title ci(appsec): connect testsuit to testagent services ci(appsec): connect testagent service to tests Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants