-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(llmobs): fix behavior for running multiple evaluators #11986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Datadog ReportBranch report: ✅ 0 Failed, 219 Passed, 1379 Skipped, 7m 8.35s Total duration (34m 47.25s time saved) |
lievan
added
the
changelog/no-changelog
A changelog entry is not required for this PR.
label
Jan 16, 2025
lievan
changed the title
chore(llmobs): fix behavior for running multiple evaluators
chore(llmobs): fix behavior for running multiple evaluators
Jan 16, 2025
Yun-Kim
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was unexpected behavior when turning on multiple evaluators where only the last evaluator in the evaluators list was being run multiple times for one span.
Fix it by replacing
executor.map
with just individual calls toexecutor.submit
, which should do the same thing but it avoids the the unexpected behavior aboveTo reproduce: the added test case in this PR fails if we switch back to
executor.map
. See this CI run for the reproduced errorChecklist
Reviewer Checklist