Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): reset all profiling c++ mutexes on fork [backport 2.17] #11991

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Jan 16, 2025

Manual backport of #11768 to 2.17

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Manual backport of #11768 to 2.17

---------

Co-authored-by: Taegyun Kim <[email protected]>
(cherry picked from commit d855c4a)
@taegyunkim taegyunkim requested review from a team as code owners January 16, 2025 21:57
@taegyunkim taegyunkim added the Profiling Continous Profling label Jan 16, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

releasenotes/notes/fix-profiling-native-mutices-62440b5a3d9d6c4b.yaml   @DataDog/apm-python
ddtrace/internal/datadog/profiling/dd_wrapper/include/uploader_builder.hpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/code_provenance.cpp   @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/ddup_interface.cpp    @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/profile.cpp           @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/uploader.cpp          @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/uploader_builder.cpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/stack_v2/src/sampler.cpp             @DataDog/profiling-python
ddtrace/internal/datadog/profiling/stack_v2/src/thread_span_links.cpp   @DataDog/profiling-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: backport-11768-to-2.17
Commit report: 52a4383
Test service: dd-trace-py

✅ 0 Failed, 592 Passed, 694 Skipped, 19m 11.57s Total duration (17m 26.47s time saved)

@taegyunkim taegyunkim changed the title fix(profiling): reset all profiling c++ mutexes on fork fix(profiling): reset all profiling c++ mutexes on fork [backport 2.17] Jan 16, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2025

Benchmarks

Benchmark execution time: 2025-01-16 22:36:39

Comparing candidate commit 52a4383 in PR branch backport-11768-to-2.17 with baseline commit a20b4c2 in branch 2.17.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 378 metrics, 0 unstable metrics.

@taegyunkim taegyunkim enabled auto-merge (squash) January 16, 2025 22:51
@taegyunkim taegyunkim disabled auto-merge January 17, 2025 14:57
@taegyunkim taegyunkim merged commit 87ce8ad into 2.17 Jan 17, 2025
644 of 649 checks passed
@taegyunkim taegyunkim deleted the backport-11768-to-2.17 branch January 17, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants