Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): iast code injection error with locals and globals #11996

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Jan 17, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

gnufede and others added 2 commits January 17, 2025 12:59
@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jan 17, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/appsec/_iast/taint_sinks/code_injection.py                      @DataDog/asm-python
tests/appsec/iast/fixtures/taint_sinks/code_injection.py                @DataDog/asm-python
tests/appsec/iast/taint_sinks/test_code_injection.py                    @DataDog/asm-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: avara1986/fix-iast_code_injection
Commit report: 75bffb6
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 30.08s Total duration (35m 28.18s time saved)

@avara1986 avara1986 marked this pull request as ready for review January 17, 2025 13:07
@avara1986 avara1986 requested a review from a team as a code owner January 17, 2025 13:07
@pr-commenter
Copy link

pr-commenter bot commented Jan 17, 2025

Benchmarks

Benchmark execution time: 2025-01-17 13:20:49

Comparing candidate commit 75bffb6 in PR branch avara1986/fix-iast_code_injection with baseline commit 400053f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@avara1986 avara1986 merged commit f67a358 into main Jan 17, 2025
713 of 714 checks passed
@avara1986 avara1986 deleted the avara1986/fix-iast_code_injection branch January 17, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants