-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(trace_utils): move implementation details to internal [3.0] #12002
base: main
Are you sure you want to change the base?
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 25.06s Total duration (35m 22.28s time saved) |
BenchmarksBenchmark execution time: 2025-01-17 22:47:20 Comparing candidate commit 4d9b132 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
Motivation
ddtrace.contrib.internal
package is self contained and does rely onddtrace.contrib
public interfaces.Changes
ddtrace.contrib.redis_utils
module. Expose all public redis_utils inddtrace.contrib.trace_utils
(for now).ddtrace.contrib.trace_utils_async
module. Expose all public async utils toddtrace.contrib.trace_utils
.trace_handlers
,func_name
,module_name
, andrequire_modules
functions exposed inddtrace.contrib.__init__
. These functions are internal to ddtrace.trace_utils
,trace_utils_async
, andredis_utils
toddtrace.contrib.internal.trace_util
.Checklist
Reviewer Checklist