-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL: Report multiple query errors #4177
base: master
Are you sure you want to change the base?
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 22066 Passed, 1476 Skipped, 5m 30.76s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4177 +/- ##
==========================================
- Coverage 97.71% 97.71% -0.01%
==========================================
Files 1358 1358
Lines 82501 82549 +48
Branches 4223 4226 +3
==========================================
+ Hits 80618 80659 +41
- Misses 1883 1890 +7 ☔ View full report in Codecov by Sentry. |
af565a0
to
10f8fe3
Compare
10f8fe3
to
523aa51
Compare
👋 Hey @marcotc, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md (possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None. (possible answers No/Nope/None) Visited at: 2025-01-18 00:02:08 UTC |
523aa51
to
418a657
Compare
@@ -11,7 +11,7 @@ on: | |||
env: | |||
REGISTRY: ghcr.io | |||
REPO: ghcr.io/datadog/dd-trace-rb | |||
SYSTEM_TESTS_REF: main # This must always be set to `main` on dd-trace-rb's master branch | |||
SYSTEM_TESTS_REF: marcotc/graphql-error-events # This must always be set to `main` on dd-trace-rb's master branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder: remove this before merging.
Leaving this here during code review because it proves that this PR passes system-test changes.
Co-authored-by: datadog-datadog-prod-us1[bot] <88084959+datadog-datadog-prod-us1[bot]@users.noreply.github.com>
Captures GraphQL error information as span events:
This is necessary because each query can have multiple errors (GraphQL spec for the "errors" field), which cannot reported using span tags (span tags only support one error per span).
Change log entry
GraphQL query errors are now reported as Span Events. This includes support for multiple errors, if present.
How to test the change?
All changes have unit tests and system-tests: DataDog/system-tests#3840