Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dependencies by moving rubocop to check group #4276

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Jan 10, 2025

What does this PR do?

Remove redundant dependencies required for appraisal groups.

Motivation:

Previous PR: #4198, allow us to shrink the size of Gemfile by moving default dependencies into check group, which is only used during specific situation. While those groups are used to introduce dependencies for testing integrations.

Change log entry
No

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner January 10, 2025 14:30
Copy link

github-actions bot commented Jan 10, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-01-10 14:40:11 UTC

@TonyCTHsu TonyCTHsu added dev/testing Involves testing processes (e.g. RSpec) dev/ci Involves CircleCI, GitHub Actions, or GitLab labels Jan 10, 2025
@TonyCTHsu TonyCTHsu changed the title Move rubocop group Cleanup dependencies by moving rubocop to check group Jan 10, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 10, 2025

Datadog Report

Branch report: tonycthsu/rubocop-group
Commit report: 76c0d81
Test service: dd-trace-rb

✅ 0 Failed, 22130 Passed, 1472 Skipped, 5m 25.34s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 10, 2025

Benchmarks

Benchmark execution time: 2025-01-10 15:12:01

Comparing candidate commit 76c0d81 in PR branch tonycthsu/rubocop-group with baseline commit 7f8e8fd in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (7f8e8fd) to head (76c0d81).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4276      +/-   ##
==========================================
+ Coverage   97.70%   97.72%   +0.01%     
==========================================
  Files        1354     1354              
  Lines       82418    82418              
  Branches     4220     4220              
==========================================
+ Hits        80530    80543      +13     
+ Misses       1888     1875      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu merged commit 7c02a1c into master Jan 10, 2025
388 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/rubocop-group branch January 10, 2025 15:17
@github-actions github-actions bot added this to the 2.9.0 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants