DEBUG-3328 report DI status in environment logger summary #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2025-01-14 19:32:47 Comparing candidate commit 22b8070 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:tracing - Propagation - Trace Context
|
marcotc
approved these changes
Jan 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4285 +/- ##
==========================================
- Coverage 97.72% 97.72% -0.01%
==========================================
Files 1354 1354
Lines 82410 82455 +45
Branches 4213 4216 +3
==========================================
+ Hits 80538 80577 +39
- Misses 1872 1878 +6 ☔ View full report in Codecov by Sentry. |
Merged
p-datadog
pushed a commit
that referenced
this pull request
Jan 15, 2025
* master: (161 commits) Bump to version 2.9.0 (#4293) Increase type checking coverage (#4290) DEBUG-3329 rename datadog/di/init to datadog/di/preload (#4288) update supported versions workflow (#4289) DEBUG-3182 DI railtie (#4272) DEBUG-3328 report DI status in environment logger summary (#4285) Move out ostruct gem from test group for Ruby 3.5 DEBUG-3316 verify code tracking works in forked processes (#4284) Fix rebase issue in Rack::RequestMiddleware Improve code style in AppSec rack middlewares Improve variable naming in Rack::RequestBodyMiddleware Improve variable naming in Rack::RequestMiddleware Simplify Rack::RequestMiddleware Switch AppSec rack blocking to throw Extract to .gitlab/scripts Implement polling vaccine Update RBS signatures Add new RSpec negate matcher not_change Replace direct AppSec::Processor::Context calls Change AppSec::Context exposed interface ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the state of dynamic instrumentation to environment logger summary reporting.
Motivation:
For troubleshooting it would be helpful to see whether DI is effectively turned on (i.e. it's requested to be on programmatically or via an environment variable, and environmental conditions are appropriate (environment, Ruby version, etc.))
Change log entry
Yes: library will report whether dynamic instrumentation is enabled in startup summary report
Additional Notes:
How to test the change?
Unit tests are included