Wait for build to complete before launching browser #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
web-ext
is launched before the build has completed, there is a crash (below) because it cannot find the manifest file. Currently, the build is started but not awaited. Because of this,web-ext
is only run successfully when by coincidence the build is finished faster thanweb-ext
tries to access the manifest. In my experience, this only happens when I haven't launched Firefox since rebooting.This pull request makes sure the initial build is awaited before launching the browser.
Error when
web-ext
runs before the build is finished: