-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added keypoint matplotlib viewer #90
Added keypoint matplotlib viewer #90
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 83.18% 83.05% -0.13%
==========================================
Files 11 11
Lines 1540 1688 +148
==========================================
+ Hits 1281 1402 +121
- Misses 259 286 +27
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Preview page for your plugin is ready here: |
demo.mov |
Probably a couple of tweaks that could be made here and there; but that works very smoothly even for maDLC. |
Another thing that should be tweaked @jeylau : They y_lim should be independent of the dataset and dependent on the plot window (or adjustable) |
Good point; one thing that could be added then is a |
Is this superseded by #92 ? |
@MMathisLab, these 2 PRs are distinct components. I will add the toolbar Seb mentioned above so this one is ready 😊 |
Also, regarding the warnings in the console, they will be removed with napari's next release and vispy >= 0.13 napari/napari#6025 |
I think we need to address failing tests here before merge, right? |
Mhhh, napari removed the plugin preview service chanzuckerberg/napari-hub#1216. I'll delete the github action. |
so, ready to merge? |
Yes, looking good to me! |
Matplotliib viewer to view your keypoints' trajectory synced with the video and keypoints.
Activate plugin, upload your .h5 (and video, not necessary), and tick "show matplotlib trajectory"
Needs to be adapted to keypoints from the GUI directly, in here:
napari-deeplabcut-traj_viewer_skeleton.mov