Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added keypoint matplotlib viewer #90

Merged
merged 9 commits into from
Sep 15, 2023

Conversation

hausmanns
Copy link
Contributor

@hausmanns hausmanns commented Aug 25, 2023

Matplotliib viewer to view your keypoints' trajectory synced with the video and keypoints.

Activate plugin, upload your .h5 (and video, not necessary), and tick "show matplotlib trajectory"

  • Needs a fix: For now it's still hardcoded to the naming of my keypoints of interests.
    Needs to be adapted to keypoints from the GUI directly, in here:

image

napari-deeplabcut-traj_viewer_skeleton.mov

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Merging #90 (ff625fa) into main (4d34cd2) will decrease coverage by 0.13%.
Report is 6 commits behind head on main.
The diff coverage is 82.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   83.18%   83.05%   -0.13%     
==========================================
  Files          11       11              
  Lines        1540     1688     +148     
==========================================
+ Hits         1281     1402     +121     
- Misses        259      286      +27     
Files Changed Coverage Δ
src/napari_deeplabcut/_widgets.py 73.36% <82.00%> (+1.83%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Aug 30, 2023

Preview page for your plugin is ready here:
https://preview.napari-hub.org/DeepLabCut/napari-deeplabcut/90
Updated: 2023-08-31T08:05:01.184269

@MMathisLab MMathisLab requested a review from jeylau August 30, 2023 12:29
@jeylau
Copy link
Contributor

jeylau commented Aug 31, 2023

demo.mov

@jeylau
Copy link
Contributor

jeylau commented Aug 31, 2023

Probably a couple of tweaks that could be made here and there; but that works very smoothly even for maDLC.

@hausmanns
Copy link
Contributor Author

hausmanns commented Aug 31, 2023

Another thing that should be tweaked @jeylau :

They y_lim should be independent of the dataset and dependent on the plot window (or adjustable)
Indeed, keypoint jumps can squeeze the window depending on the dataset's quality

@jeylau
Copy link
Contributor

jeylau commented Aug 31, 2023

Good point; one thing that could be added then is a NavigationToolbar2QT, which would allow panning, zooming, etc.

@MMathisLab
Copy link
Member

MMathisLab commented Sep 14, 2023

Is this superseded by #92 ?

@jeylau
Copy link
Contributor

jeylau commented Sep 14, 2023

@MMathisLab, these 2 PRs are distinct components. I will add the toolbar Seb mentioned above so this one is ready 😊

@jeylau
Copy link
Contributor

jeylau commented Sep 14, 2023

Also, regarding the warnings in the console, they will be removed with napari's next release and vispy >= 0.13 napari/napari#6025

@MMathisLab
Copy link
Member

I think we need to address failing tests here before merge, right?

@jeylau
Copy link
Contributor

jeylau commented Sep 14, 2023

Mhhh, napari removed the plugin preview service chanzuckerberg/napari-hub#1216. I'll delete the github action.

@MMathisLab
Copy link
Member

so, ready to merge?

@jeylau
Copy link
Contributor

jeylau commented Sep 15, 2023

Yes, looking good to me!

@MMathisLab MMathisLab self-requested a review September 15, 2023 14:29
setup.cfg Outdated Show resolved Hide resolved
@MMathisLab MMathisLab merged commit 0e04f2f into DeepLabCut:main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants