Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow saving invalid sites #215

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow saving invalid sites #215

wants to merge 2 commits into from

Conversation

IanVS
Copy link
Contributor

@IanVS IanVS commented Jan 10, 2025

Closes #191

@nbrownus would like us to be able to save an invalid site, as a way of saving partial progress and then fixing issues later on, so that's what this PR does, for both Android and iOS. To test, add a site, give it a name, and press save. You should be taken to a list of sites, including the newly created invalid site.

@IanVS IanVS requested review from johnmaguire and nbrownus January 10, 2025 20:15
@johnmaguire
Copy link
Member

Went through Git history to see if there was a reason for getKey but it has existed since initial commit, so I expect it's an artifact of keeping state clean during development. It should be possible to still delete the site with an invalid key and recreate it. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking save on an unvalidated form closes the form without saving
2 participants