Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Enable SVG Badge support (unauthenticated)" checkbox in favor of authenticated badge API #985

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/i18n/locales/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"enable_default_template_override": "Überschreiben der Standardvorlage aktivieren",
"enable_email": "E-Mail aktivieren",
"enable_index_consistency_check": "Regelmäßige Konsistenzprüfungen aktivieren",
"enable_svg_badge": "SVG-Badge-Unterstützung aktivieren (nicht authentifiziert)",
"enabled": "Aktiviert",
"enabled_for_tags": "Aktiviert für Tags",
"experimental": "Experimentell",
Expand Down
1 change: 0 additions & 1 deletion src/i18n/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"enable_default_template_override": "Enable default template override",
"enable_email": "Enable email",
"enable_index_consistency_check": "Enable periodic consistency check",
"enable_svg_badge": "Enable SVG badge support (unauthenticated)",
"enabled": "Enabled",
"enabled_for_tags": "Enabled for tags",
"experimental": "Experimental",
Expand Down
1 change: 0 additions & 1 deletion src/i18n/locales/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"enable_default_template_override": "Habilitar anulación de plantilla predeterminada",
"enable_email": "Habilitar correo electrónico",
"enable_index_consistency_check": "Habilitar la verificación periódica de coherencia",
"enable_svg_badge": "Habilitar la compatibilidad con insignias SVG (sin autenticar)",
"enabled": "Activado",
"enabled_for_tags": "Habilitado para etiquetas",
"experimental": "Experimental",
Expand Down
1 change: 0 additions & 1 deletion src/i18n/locales/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"enable_default_template_override": "Activer le remplacement du modèle par défaut",
"enable_email": "Activer l'envoi de courriels",
"enable_index_consistency_check": "Activer le contrôle de cohérence périodique",
"enable_svg_badge": "Activer la prise en charge des badges SVG (non authentifiés)",
"enabled": "Activé",
"enabled_for_tags": "Activé pour les balises",
"experimental": "Expérimental",
Expand Down
1 change: 0 additions & 1 deletion src/i18n/locales/hi.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"enable_default_template_override": "डिफ़ॉल्ट टेम्पलेट ओवरराइड सक्षम करें",
"enable_email": "ईमेल सक्षम करें",
"enable_index_consistency_check": "आवधिक संगतता जांच सक्षम करें",
"enable_svg_badge": "SVG बैज समर्थन सक्षम करें (अप्रमाणित)",
"enabled": "सक्रिय",
"enabled_for_tags": "टैग के लिए सक्षम",
"experimental": "प्रयोगात्मक",
Expand Down
1 change: 0 additions & 1 deletion src/i18n/locales/it.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"enable_default_template_override": "Abilita l'override del modello predefinito",
"enable_email": "Abilita e-mail",
"enable_index_consistency_check": "Abilita il controllo periodico della coerenza",
"enable_svg_badge": "Abilita il supporto del badge SVG (non autenticato)",
"enabled": "Abilitato",
"enabled_for_tags": "Abilitato per i tag",
"experimental": "Sperimentale",
Expand Down
1 change: 0 additions & 1 deletion src/i18n/locales/ja.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"enable_default_template_override": "デフォルトのテンプレートのオーバーライドを有効にする",
"enable_email": "メールを有効にする",
"enable_index_consistency_check": "定期的な整合性チェックを有効にする",
"enable_svg_badge": "SVG バッジのサポートを有効にする (認証なし)",
"enabled": "有効",
"enabled_for_tags": "タグに対して有効化",
"experimental": "実験的",
Expand Down
1 change: 0 additions & 1 deletion src/i18n/locales/pl.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"enable_default_template_override": "Włącz domyślne zastąpienie szablonu",
"enable_email": "Włącz pocztę e-mail",
"enable_index_consistency_check": "Włącz okresową kontrolę spójności",
"enable_svg_badge": "Włącz obsługę plakietek SVG (nieuwierzytelnione)",
"enabled": "Włączony",
"enabled_for_tags": "Włączono dla tagów",
"experimental": "Eksperymentalny",
Expand Down
1 change: 0 additions & 1 deletion src/i18n/locales/pt-BR.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"enable_default_template_override": "Habilitar substituição de modelo padrão",
"enable_email": "Ativar e-mail",
"enable_index_consistency_check": "Habilitar verificação periódica de consistência",
"enable_svg_badge": "Ativar suporte para emblema SVG (não autenticado)",
"enabled": "Habilitado",
"enabled_for_tags": "Ativado para tags",
"experimental": "Experimental",
Expand Down
1 change: 0 additions & 1 deletion src/i18n/locales/pt.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"enable_default_template_override": "Habilitar substituição de modelo padrão",
"enable_email": "Ativar e-mail",
"enable_index_consistency_check": "Habilitar verificação periódica de consistência",
"enable_svg_badge": "Ativar suporte para emblema SVG (não autenticado)",
"enabled": "Habilitado",
"enabled_for_tags": "Ativado para tags",
"experimental": "Experimental",
Expand Down
1 change: 0 additions & 1 deletion src/i18n/locales/ru.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"enable_default_template_override": "Включить переопределение шаблона по умолчанию",
"enable_email": "Включить электронную почту",
"enable_index_consistency_check": "Включить периодическую проверку согласованности",
"enable_svg_badge": "Включить поддержку значков SVG (без аутентификации)",
"enabled": "Включено",
"enabled_for_tags": "Включено для тегов",
"experimental": "Экспериментальный",
Expand Down
1 change: 0 additions & 1 deletion src/i18n/locales/uk-UA.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"enable_default_template_override": "Увімкнути заміну шаблону за замовчуванням",
"enable_email": "Увімкнути електронну пошту",
"enable_index_consistency_check": "Увімкнути періодичну перевірку узгодженості",
"enable_svg_badge": "Увімкнути підтримку значка SVG (не автентифіковано)",
"enabled": "Увімкнено",
"enabled_for_tags": "Увімкнено для тегів",
"experimental": "Експериментальний",
Expand Down
1 change: 0 additions & 1 deletion src/i18n/locales/zh.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"enable_default_template_override": "启用默认模板覆盖",
"enable_email": "启用电子邮件",
"enable_index_consistency_check": "启用定期一致性检查",
"enable_svg_badge": "启用 SVG 徽章支持(未经身份验证)",
"enabled": "已启用",
"enabled_for_tags": "为标签启用",
"experimental": "实验性的",
Expand Down
23 changes: 0 additions & 23 deletions src/views/administration/configuration/General.vue
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,6 @@
v-model="baseUrl"
tooltip="This URL is used to construct links back to Dependency-Track from external systems."
/>
<c-switch
id="isBadgesEnabled"
color="primary"
v-model="isBadgesEnabled"
label
v-bind="labelIcon"
/>{{ $t('admin.enable_svg_badge') }}
</b-card-body>
<b-card-footer>
<b-button variant="outline-primary" class="px-4" @click="saveChanges">{{
Expand All @@ -27,10 +20,8 @@
</template>

<script>
import { Switch as cSwitch } from '@coreui/vue';
import { ValidationObserver } from 'vee-validate';
import BValidatedInputGroupFormInput from '../../../forms/BValidatedInputGroupFormInput';
import common from '../../../shared/common';
import configPropertyMixin from '../mixins/configPropertyMixin';

export default {
Expand All @@ -39,18 +30,12 @@ export default {
header: String,
},
components: {
cSwitch,
ValidationObserver,
BValidatedInputGroupFormInput,
},
data() {
return {
baseUrl: '',
isBadgesEnabled: false,
labelIcon: {
dataOn: '\u2713',
dataOff: '\u2715',
},
};
},
methods: {
Expand All @@ -61,11 +46,6 @@ export default {
propertyName: 'base.url',
propertyValue: this.baseUrl,
},
{
groupName: 'general',
propertyName: 'badge.enabled',
propertyValue: this.isBadgesEnabled,
},
]);
},
},
Expand All @@ -80,9 +60,6 @@ export default {
case 'base.url':
this.baseUrl = item.propertyValue;
break;
case 'badge.enabled':
this.isBadgesEnabled = common.toBoolean(item.propertyValue);
break;
}
}
});
Expand Down
Loading