Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Modernize Renderer #510

Closed
wants to merge 28 commits into from

Conversation

tophyr
Copy link
Contributor

@tophyr tophyr commented Aug 2, 2024

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Modernize the Descent 3 renderer to use OpenGL 3 (GLES 3, eventually) and shaders.

Rendering behavior should be identical! Any difference should be considered a bug, unless discussed, determined to be acceptable, and specifically called out here.

This PR is a work in progress and will be rebased and rewritten often. As the code, documentation and commit descriptions mature, this will be made review-ready.

Current Status + Known Issues

  • Boots and can enter Pilot Training mission on Mac. See Screenshots 1 & 2.
  • Texture or lighting issues, seems dependent on ship orientation? See attached Screenshots, 3-8
  • Polygon vertex order may need attention: GL_POLYGON was deprecated and GL_TRIANGLE_FAN is being used, but I don't think is quite the same thing.
    • Environment, at least, seems to render mostly fine however

Screenshots

1: Game Intro Screen

Screenshot 2024-08-02 at 1 35 36 AM

2: Pilot Training Mission

Screenshot 2024-08-02 at 1 35 46 AM

3: Lighting state changes?

Screenshot 2024-08-02 at 1 35 59 AM

4: Missing light on left side

Screenshot 2024-08-02 at 1 36 05 AM

5: Lighting or texture type change

Screenshot 2024-08-02 at 1 36 17 AM

6: Texture change - seems "simpler"

Screenshot 2024-08-02 at 1 36 22 AM

7: Wonky flat texture state? Repeatable by rotating ship 180* in Pilot Training mission

Screenshot 2024-08-02 at 1 36 40 AM

8

Screenshot 2024-08-02 at 1 36 49 AM

Related Issues

Tip of the hat to https://github.com/InsanityBringer/PiccuEngine

@tophyr tophyr changed the title DRAFT: Modernize Renderer WIP: Modernize Renderer Aug 2, 2024
@tophyr tophyr marked this pull request as draft August 2, 2024 05:25
@tophyr tophyr force-pushed the wip/modernize-renderer branch from 1a61f4e to c70f3fa Compare August 2, 2024 06:37
@tophyr tophyr force-pushed the wip/modernize-renderer branch from c70f3fa to 6e51457 Compare August 13, 2024 00:18
@tophyr
Copy link
Contributor Author

tophyr commented Aug 13, 2024

Superceded by #527

@tophyr tophyr closed this Aug 13, 2024
@tophyr tophyr deleted the wip/modernize-renderer branch August 13, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant