-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Modernize Renderer #510
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tophyr
force-pushed
the
wip/modernize-renderer
branch
from
August 2, 2024 06:37
1a61f4e
to
c70f3fa
Compare
…ngState is redundant with rend_SetLighting
eliminate gl(Enable|Disable)ClientState and glClientActiveTextureARB
tophyr
force-pushed
the
wip/modernize-renderer
branch
from
August 13, 2024 00:18
c70f3fa
to
6e51457
Compare
Superceded by #527 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Modernize the Descent 3 renderer to use OpenGL 3 (GLES 3, eventually) and shaders.
Rendering behavior should be identical! Any difference should be considered a bug, unless discussed, determined to be acceptable, and specifically called out here.
This PR is a work in progress and will be rebased and rewritten often. As the code, documentation and commit descriptions mature, this will be made review-ready.
Current Status + Known Issues
GL_POLYGON
was deprecated andGL_TRIANGLE_FAN
is being used, but I don't think is quite the same thing.Screenshots
1: Game Intro Screen
2: Pilot Training Mission
3: Lighting state changes?
4: Missing light on left side
5: Lighting or texture type change
6: Texture change - seems "simpler"
7: Wonky flat texture state? Repeatable by rotating ship 180* in Pilot Training mission
8
Related Issues
Tip of the hat to https://github.com/InsanityBringer/PiccuEngine