Fix level loading

[pzychotic]

Pull Request Type

• GitHub Workflow changes
• Documentation or Wiki changes
• Build and Dependency changes
• Runtime changes
  • Render changes
  • Audio changes
  • Input changes
  • Network changes
  • Other changes

Description

I believe some changes from #591 broke loading levels or anything that loads dynamic libs from hog files (at least on Windows). Instead of loading the new x64 DLLs from d3-win.hog, the old x86 DLLs from the original game data are loaded, which fails spectacularly.

There is this comment still, that isn't true anymore:

Descent3/Descent3/init.cpp

Lines 1504 to 1505 in 3a7c86a

	// last library opened is the first to be searched for dynamic libs, so put
	// this one at the end to find our newly build script libraries first

Osiris_ExtractScriptsFromHog() will happily overwrite existing entries of foo.dll in OSIRIS_Extracted_scripts with the last loaded temp filename from either d3.hog or any .mn3 file loaded at level start.

Trying to fix the problem, I asked myself: Why do we even load the old dynamic libs at all? We extract both old and new libs to the temp directory, only to ignore the old ones and only load the new ones. We can skip all that and only extract and load the new ones. Which this PR tries to do.

On Linux/Mac we might have a subtle difference. Since the original builds are already x64 and loading the old dynamic libs might just work, without us realizing that we don't load our new/fixed code from d3-linux|mac.hog.

Related Issues

Screenshots (if applicable)

Checklist

• I have tested my changes locally and verified that they work as intended.
• I have documented any new or modified functionality.
• I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
• I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

[winterheart]

This issue addressed by #603, one of commits removes extraction from outdated hogs and prevents extraction for already extracted scripts.

[pzychotic]

Oh, I wasn't aware that we already have a related issue #605 for this and even a fix in #607.

@winterheart Can you please incorporate my 2nd commit from here (a9f335a), since the MAX_LOADED_MODULES limit was increased only to account for the loading old and new libs from hog files, which we don't do anymore.

Duplicate of #603