Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce MAX_LOADED_MODULES to its original value #610

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

pzychotic
Copy link
Contributor

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

MAX_LOADED_MODULES was increased after introduction of d3-win.hog to account for the new x64 DLLs being loaded additional to existing DLLs from original game data. With #603 we don't load the old libs anymore and the limit can be reduced to its original value.

Related Issues

Followup to #603

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

MAX_LOADED_MODULES was increased after introduction of d3-win.hog to account for the new x64 DLLs being loadad additional to exisiting DLLs from original game data.
@winterheart
Copy link
Collaborator

Verified on Linux, no issues found.

@winterheart winterheart merged commit 117e7d2 into DescentDevelopers:main Sep 29, 2024
10 checks passed
@pzychotic pzychotic deleted the followup-to-603 branch September 29, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants