ddebug submodule update #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is stubbed and does nothing.
Reworked ASSERT() and Int3() macros to use SDL_assert(). SDL_assert() allows to debug break from user decision. Major reorganizing platform-dependent code to make it platform-independent.
Lgt2x
reviewed
Oct 4, 2024
| if (DebugBreak_callback_resume) \ | ||
| (*DebugBreak_callback_resume)(); \ | ||
| } while (0) | ||
|
|
||
| // Does a DEBUG_BREAK() if debugging is turned on. | ||
| #define Int3() \ |
There was a problem hiding this comment.
while we're renaming stuff, we should also rename Int3 to something like abort (you can suggest a better name), Int3 is an assembly instruction without much semantic
There was a problem hiding this comment.
There too much Int3() usage, PR would be much wider. If this OK, I'd propose ABORT()
Lgt2x
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This PR refactors and unifies ddebug submodule to use
SDL_assert()for all platforms. SinceSDL_assert()implements owndebug_breakfunctionality, bundled version is redundant. Synced DMFC macros with ddebug since there was some compatibility issues. Error handling (pserror.h) is also moved from misc submodule to ddebug.Related Issues
Screenshots (if applicable)
SDL_assert window on Linux
SDL_assert window on Windows
Checklist
Additional Comments