feat: add hide own repository filter checkbox #96
Conversation
src/pages/stats/[login].tsx
Outdated
| ? repositories?.filter( | ||
| // apply hideOwnRepo filter if checked | ||
| (repoData) => | ||
| repoData.repository.owner.login !== session?.user.login | ||
| ) |
There was a problem hiding this comment.
The logic that filters out own repos is written here and replicated in lines 48-51.
Maybe we should either run it once on top of this function or extract the filtering logic in a separate function, what do you think?
src/pages/stats/[login].tsx
Outdated
| @@ -225,6 +241,16 @@ export default function Stats() { | |||
| onChange={(e) => setSearchQuery(e.target.value)} | |||
| /> | |||
| </div> | |||
| <div className="flex sm:items-start items-center"> | |||
There was a problem hiding this comment.
Here flex-direction is row (by default), you should probably use the justify property.
There was a problem hiding this comment.
are you seeing them centered?
I see them all left-aligned
There was a problem hiding this comment.
They get centered on mobile/smaller screens
👷 Deploy request for public-github-stats pending review.Visit the deploys page to approve it
|
src/pages/stats/[login].tsx
Outdated
| const filteredOutOwnRepos = filterOutOwnRepos(filteredReposBySearchQuery); | ||
|
|
||
| // filter repositories based on search query | ||
| const query = searchQuery.toLowerCase(); | ||
| const filterRepos = repositories?.filter((repoData) => | ||
| repoData.repository.name.toLowerCase().includes(query) | ||
| ); | ||
| return hideOwnRepo ? filteredOutOwnRepos : filteredReposBySearchQuery; |
There was a problem hiding this comment.
Here you're running filterOutOwnRepos in any case, but if hideOwnRepo is false it is unnecessary.
I'd probably see this better with an if statement to return early, or if we want to keep it more functional with the ternary you should run filterOutOwnRepos directly inside the "then" of the ternary.
No description provided.