Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1500: Set the dispatch request email recipients based on the dewar barcode #848

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1500

Summary:

Local contacts no longer get dispatch request emails, but I19 staff would like to receive emails for i19 dewars. So we can implement a set of regex patterns to decide who gets an email based on the dewar barcode.

Changes:

  • Introduce a new config variable called $dispatch_email_regex, of an array of email addresses and regex patterns.
  • Add each email address to the list of recipients if the pattern matches the dewar barcode.

To test:

$dispatch_email = '[email protected]';
$dispatch_email_regex = array(
    '[email protected]' => '/.*/',
    '[email protected]' => '/.*i19.*/',
);
  • Turn on the shipping service
$use_shipping_service = True;
$use_shipping_service_redirect = True;
$shipping_service_api_url = "https://sample-shipping-test.diamond.ac.uk/api";
$shipping_service_app_url = "https://sample-shipping-test.diamond.ac.uk";
  • Request a dispatch for a dewar in the mx23694 proposal, check emails would be sent to stores.staff and mx.staff
  • Create a dewar in the cm37266 proposal, setting a future visit so the barcode contains "i19", request dispatch and check emails would be sent to stores.staff, mx.staff and i19.staff.
  • Turn off the shipping service:
$use_shipping_service = False;
$use_shipping_service_redirect = False;
  • Request a dispatch for a dewar in the mx23694 proposal, check emails would be sent to stores.staff and mx.staff
  • Create a dewar in the cm37266 proposal, setting a future visit so the barcode contains "i19", request dispatch and check emails would be sent to stores.staff, mx.staff and i19.staff.

Copy link
Collaborator

@gfrn gfrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the shipping service cannot reach my development machine, I've tested it out by sending a manual request to the dispatch confirmation callback endpoint, and it works as expected.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R5.3 December 3, 2024 09:25
@ndg63276 ndg63276 merged commit 6e51851 into pre-release/2024-R5.3 Dec 3, 2024
2 checks passed
ndg63276 added a commit that referenced this pull request Dec 16, 2024
…882)

* LIMS-1498: Change name of processed data archive (#855)

* LIMS-1469: Fix download button on old summary page (#840)

* LIMS-1463: Always display Mesh3D data collections as grid scans (#845)

* LIMS-1515: Add energy value to data collections (#853)

* LIMS-261: Allow download of PDB files (#857)

* LIMS-1529: Fix fast ep model viewer (#858)

* LIMS-753: Allow LN2 topups as part of dewar history (#856)

* LIMS-1530: Add To Queue Fails when Not Completed filter applied (#864)

* LIMS-1530: Add To Queue Fails when Not Completed filter applied

* LIMS-1552: Remove old jquery (#871)

* LIMS-1500: Set the dispatch request email recipients based on the dewar barcode (#848)

* LIMS-1458: Fix GitHub warnings (#841)

---------

Co-authored-by: Mark Williams <[email protected]>
Co-authored-by: Guilherme Francisco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants