Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-1487: Fix alphafold triggering #866

Merged
merged 1 commit into from
Dec 16, 2024
Merged

LIMS-1487: Fix alphafold triggering #866

merged 1 commit into from
Dec 16, 2024

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1487

Summary:

Automatic triggering of alphafold when a sequence is added was broken by the switch to rabbitmq (#826)

Changes:

  • Use rabbitmq parameters instead of activemq ones to submit jobs
  • Put the updated global variable names in the sample config

To test:

  • Put the rabbitmq variables into the config (get from prod or from Mark)
  • Find a protein in a cm proposal with no current sequence (eg /proteins/pid/604455)
  • Add a suitable sequence (eg copy from /proteins/pid/597094)
  • Check in graylog if alphafold has been triggered
  • Wait a couple of hours, some pdb files will appear in the prod database

gfrn
gfrn approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@gfrn gfrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it with a local RabbitMQ instance (the same I use for PATo), and everything seems to work

@gfrn gfrn added Ready to Release Configuration Change Pull requests which necessitate changes to SynchWeb configuration labels Dec 10, 2024
@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R5.4 December 16, 2024 14:24
@ndg63276 ndg63276 merged commit 506408e into pre-release/2024-R5.4 Dec 16, 2024
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1487/fix-alphafold-triggering branch December 16, 2024 14:32
ndg63276 added a commit that referenced this pull request Jan 10, 2025
@ndg63276 @gfrn
Merge pre-release/2024-R5.4 with master (#892)
3684b32 
* LIMS-1569: Get image viewer rings from dials if possible (#875)

* LIMS-1002: Fix error when creating new laboratory (#815)

* LIMS-1302 - add visit to container even if UAS fails (#762)

* LIMS-1487: Fix alphafold triggering (#866)

* LIMS-1563 - Remove touchscreen app (#867)

Co-authored-by: Mark Williams <[email protected]>
Co-authored-by: Guilherme Francisco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfrn gfrn gfrn approved these changes

Assignees
No one assigned
Labels
Configuration Change Pull requests which necessitate changes to SynchWeb configuration Ready to Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndg63276 @gfrn