Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1564 - Remove unused dependencies #868

Conversation

gfrn
Copy link
Collaborator

@gfrn gfrn commented Nov 29, 2024

JIRA ticket: LIMS-1564

This depends on #867

Summary:

A lot of dependencies were aliased and had no impact on the application whatsoever. These are being removed, and code where they were referenced were updated to point directly to the node package instead, which makes the code easier to interpret.

Note that this is not exhaustive, and more dead can be removed.

Changes:

  • Remove unused/aliased dependencies
  • Update library imports

To test:

  • Check Uglymol still works (/dc/map/id/15928138/aid/107542405)
  • Check the docs page still renders as normal, but smooth scrolling is disabled (run a static file webserver on the /docs folder, view the resulting page)
  • Check the logistics page still renders as expected (/logistics)
  • Check visit stats, ensure all charts are rendered as expected (/stats/visit/cm37235-5)

@gfrn gfrn added javascript Pull requests that update Javascript code improvement labels Nov 29, 2024
@gfrn gfrn self-assigned this Nov 29, 2024
@gfrn gfrn added the Configuration Change Pull requests which necessitate changes to SynchWeb configuration label Dec 10, 2024
@ndg63276 ndg63276 self-requested a review January 13, 2025 11:12
Copy link
Collaborator

@ndg63276 ndg63276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R1.1 January 13, 2025 11:33
@ndg63276 ndg63276 merged commit 5116772 into pre-release/2025-R1.1 Jan 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Configuration Change Pull requests which necessitate changes to SynchWeb configuration improvement javascript Pull requests that update Javascript code Ready to Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants