Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-1605: Remove jquery-touchswipe library #895

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

LIMS-1605: Remove jquery-touchswipe library #895

wants to merge 2 commits into from

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1605

Summary:

The jquery touchswipe plugin is out of date and only used on one page. Vanilla js can do this nowadays, so we should remove the plugin.

Changes:

  • Use the touchstart and touchend events to capture swipes
  • Remove the touchSwipe library and remove it from package.json

To test:

  • Go to proposal nt37104, go to a container
  • Check on a PC that you can move between wells by clicking on the plan of the plate
  • Switch to mobile view and refresh, check that swiping left moves to the next well, and that swiping right moves to the previous image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ndg63276