Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development environment #17

Merged
merged 8 commits into from
May 31, 2024
Merged

Add development environment #17

merged 8 commits into from
May 31, 2024

Conversation

GDYendell
Copy link
Collaborator

@DominicOram hopefully this gives you a sensible development environment to work with. It adds a test that writes a file from some dumped data messages from i03. I am not sure why the ordering of the input files seems to be wrong in CI - it works locally. I would be interested to see if it works for you.

@GDYendell GDYendell assigned DominicOram and unassigned DominicOram May 25, 2024
@GDYendell GDYendell requested a review from DominicOram May 25, 2024 07:14
@GDYendell
Copy link
Collaborator Author

@graeme-winter I think the test here would provide a good place to interrogate the generated meta file in detail in CI if you can provide the code do the verification.

In future we can spin up a full odin deployment, but I think processing dumped zmq messages is a good start (and will still be a useful test in addition to a full integration test).

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked great for me other than the one comment, thank you!

.devcontainer/devcontainer.json Show resolved Hide resolved
@GDYendell GDYendell force-pushed the dev branch 4 times, most recently from 6445186 to 09730b7 Compare May 30, 2024 15:28
@GDYendell GDYendell merged commit f1f7aa7 into master May 31, 2024
15 checks passed
@GDYendell GDYendell deleted the dev branch May 31, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants