Skip to content
This repository has been archived by the owner on Jul 1, 2023. It is now read-only.

Code quality improvement, fix critical security hole #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yellowsink
Copy link

@yellowsink yellowsink commented Apr 28, 2023

Changes:

  • use lune to build the plugin
  • use the shelter injectCss API to add and remove styles
  • split the CSS out into a separate file for readability (and minification)
  • general cleanup
  • switches to the shelter model of plugin development, in which polling the DOM in a loop is replaced by a flux subscription and a DOM observation.
  • jesus christ for the love of god do not place fetch()ed data on the DOM using innerHTML - stopped that.

@yellowsink yellowsink changed the title Improvements to code quality Code quality improvement, fix critical security hole Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant