-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tooling): Switch to ruff-format for formatting. #1169
base: master
Are you sure you want to change the base?
refactor(tooling): Switch to ruff-format for formatting. #1169
Conversation
3cfc636
to
e47a5a2
Compare
e47a5a2
to
fbd43e1
Compare
fbd43e1
to
fe1372d
Compare
93d0a37
to
aa96ddf
Compare
aa96ddf
to
62778ff
Compare
Ready for consideration! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I voiced my concerns about all-in-one tooling on discord before; to summarize, not being able to update linter and formatter separately anymore isn't ideal.
If one wants to update ruff to fix a linter bug, but doesn't want the formatting changes a newer version would potentially bring, you're pretty much out of luck.
Still, I'm willing to give this a try, especially given the pretty substantial performance difference. :>
There's potential for lots of fun merge conflicts in other PRs here, so I'd prefer only merging this after the next release - hope that's understandable
Don't see much of an issue with that, but given that
We'll have a chance to test it 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
165ab84 Undo the formatting changes too
Sorry, why? |
What's the point of |
Ruff v0.5 has just been released, so technically this can move forward. I'll try and find some time to update this |
Summary
Replaces black with ruff-format.
Depends on #1168Checklist
pdm lint
pdm pyright