Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): escape / in url parameters #1264

Merged
merged 4 commits into from
Dec 29, 2024
Merged

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Dec 29, 2024

Summary

See https://docs.python.org/3.12/library/urllib.parse.html#urllib.parse.quote.

This doesn't pose an immediate risk, but is still something that should not be happening.
See also discordjs/discord-api-types@1ba3472 and h1 #2765008.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added this to the disnake v2.10 milestone Dec 29, 2024
@shiftinv shiftinv merged commit 18535bb into master Dec 29, 2024
28 checks passed
@shiftinv shiftinv deleted the fix/route-param-uriencode branch December 29, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant