Merge pull request #82 from DroidKaigi/feature/58-timetable-fix

Feature/58 timetable fix
DroidKaigi · Jun 27, 2024 · cb4f460 · cb4f460
2 parents 354d74d + b796c5b
commit cb4f460
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/core/ui/build.gradle.kts b/core/ui/build.gradle.kts
@@ -18,6 +18,7 @@ kotlin {
                 implementation(libs.kermit)
                 api(projects.core.common)
                 api(libs.coil)
+                api(libs.coilNetwork)
                 api(libs.kotlinxDatetime)
                 implementation(libs.moleculeRuntime)
                 implementation(libs.coreBundle)

diff --git a/...ns/src/commonMain/kotlin/io/github/droidkaigi/confsched/sessions/section/TimetableList.kt b/...ns/src/commonMain/kotlin/io/github/droidkaigi/confsched/sessions/section/TimetableList.kt
@@ -143,7 +143,7 @@ fun TimetableList(
                 )
                 timetableItem.speakers.forEach { speaker ->
                     Row {
-                        // TODO: This style of image loading was included by default but it seems slow
+                        // TODO: Fixed image loading again but its still slow. Maybe we need smaller images?
                         val painter = rememberAsyncImagePainter(speaker.iconUrl)
                         Image(
                             painter = painter,
@@ -161,6 +161,7 @@ fun TimetableList(
                                 .padding(5.dp)
                                 .align(Alignment.CenterVertically),
                         )
+                        // TODO: Message goes here (missing from object we can access here?)
                     }
                 }
                 // TODO: There is no data for the warning string right now. (Should go here)

diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -109,6 +109,7 @@ coreBundle = { module = "org.jetbrains.androidx.core:core-bundle", version = "1.
 composeHiltNavigtation = { module = "androidx.hilt:hilt-navigation-compose", version.ref = "composeHiltNavigatiaon" }
 composeLintCheck = { module = "com.slack.lint.compose:compose-lint-checks", version = "1.3.1" }
 coil = { module = "io.coil-kt.coil3:coil-compose", version.ref = "coil" }
+coilNetwork = { module = "io.coil-kt.coil3:coil-network-ktor", version.ref = "coil"  }
 coilTest = { module = "io.coil-kt.coil3:coil-test", version.ref = "coil" }
 composeShimmer = { module = "com.valentinilk.shimmer:compose-shimmer", version = "1.0.5" }
 rin = { module = "io.github.takahirom.rin:rin", version.ref = "rin" }