Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 [Compose Multiplatform] Fixed navigation to work properly on both iOS and Android. #1010

Conversation

Corvus400
Copy link
Contributor

@Corvus400 Corvus400 commented Sep 8, 2024

Issue

Overview (Required)

  • At first, it was thought that the problem could be solved by increasing the version of composeMultiplatform, as in the following commit, so the version was increased.
  • However, later investigation revealed that this version did not yet contain the fix for the problem.
  • At that time, it was discovered that there was a workaround, so we tried that and were able to confirm that the problem on the iOS side had been solved.

Links

Movie (Optional)

iOS Before iOS After
ios.before.mov
ios.after.mov
Android Before Android After
android.before.mp4
android.after.mp4

…roperly due to a bug in the Compose Multiplatform Core side, the version will be upgraded to one that has a fix.

At that time, it was said that CADisableMinimumFrameDurationOnPhone should be set to true, so I set it to true.
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 8, 2024 14:44 Inactive
@takahirom
Copy link
Member

It seems that the change isn't released yet. 👀

@takahirom
Copy link
Member

takahirom commented Sep 8, 2024

Now that we can access the issues, it seems there are some workarounds, and workaround 2 looks easier. I think we can just pass the navController.
JetBrains/compose-multiplatform#4735 (comment)

@Corvus400 Corvus400 changed the title 🔧 [Under investigation] Fixed navigation to work properly on both iOS and Android. 🔧 Fixed navigation to work properly on both iOS and Android. Sep 8, 2024
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 8, 2024 16:27 Inactive
…not working properly due to a bug in the Compose Multiplatform Core side, the version will be upgraded to one that has a fix."

This reverts commit c9cd6f3.
@Corvus400
Copy link
Contributor Author

Corvus400 commented Sep 8, 2024

It seems that the change isn't released yet. 👀

This commit is probably unnecessary. 🤔
Even if you revert this commit, it seems that the iOS issue has been resolved. 🥳
I'll revert it. 🏃

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 8, 2024 16:53 Inactive
@Corvus400 Corvus400 marked this pull request as ready for review September 8, 2024 17:05
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for trying everything we can.

@takahirom takahirom merged commit 3f6345e into DroidKaigi:main Sep 9, 2024
7 checks passed
@takahirom takahirom added the awesome Label for project-applicable insights or remarkable technologies. label Sep 9, 2024
@Corvus400 Corvus400 changed the title 🔧 Fixed navigation to work properly on both iOS and Android. 🔧 [Compose Multiplatform] Fixed navigation to work properly on both iOS and Android. Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awesome Label for project-applicable insights or remarkable technologies. type:iOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS・Compose Multiplatform] Navigation on about isn't working as expected
2 participants