Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement event map screen #105

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Implement event map screen #105

merged 5 commits into from
Jul 10, 2024

Conversation

mtkw0127
Copy link
Contributor

@mtkw0127 mtkw0127 commented Jul 9, 2024 •
edited
Loading

Issue

Overview (Required)

I implemented the screen of event map with reference to figma.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After
movie.webm

@mtkw0127 mtkw0127 marked this pull request as draft July 9, 2024 15:58
@mtkw0127 mtkw0127 changed the title イベントマップの実装 Implement event map screen Jul 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Snapshot diff report

File name Image
EventMapScreenTest.c
heckScreenContent_co
mpare.png
EventMapScreenTest.c
heckErrorScreenConte
nt_compare.png

@mtkw0127 mtkw0127 marked this pull request as ready for review July 9, 2024 16:58
@mtkw0127 mtkw0127 requested a review from a team July 10, 2024 03:25
takahirom
takahirom reviewed Jul 10, 2024
View reviewed changes
feature/eventmap/src/commonMain/composeResources/drawable/event_map.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composeResources 🎉

takahirom
takahirom approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This looks way better!

@takahirom takahirom merged commit 180d251 into main Jul 10, 2024
2 checks passed
@takahirom takahirom deleted the feature/implement-event-map branch July 10, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtkw0127 @takahirom