Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty profilecard module #89

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Add empty profilecard module #89

merged 4 commits into from
Jul 4, 2024

Conversation

mikanIchinose
Copy link
Contributor

Issue

Overview (Required)

  • add profilecard-module
  • create edit/card screen
  • add navigation to profilecard

Screenshot (Optional if screenshot test is present or unrelated to UI)

edit card

LINK

@mikanIchinose mikanIchinose self-assigned this Jul 3, 2024
@mikanIchinose mikanIchinose requested review from a team and takahirom July 3, 2024 10:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Snapshot diff report

File name Image
KaigiAppTest.checkMe
diumTabletLaunchShot
_compare.png
KaigiAppTest.checkSt
artupShot_compare.pn
g

@charles-b-stb
Copy link
Contributor

Please fix the broken unit tests if possible.

@mikanIchinose
Copy link
Contributor Author

fixed it!

takahirom
takahirom approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I have one suggestion. I recommend adding screenshot tests first, as the event map screen does, because it helps reviewers to see the changes in your screen. You can merge this PR without this but I recommend adding screenshot tests before you apply the design.

@takahirom
Copy link
Member

I think it will work if you copy this file and the robolectric.properties file, and rename them accordingly.
https://github.com/DroidKaigi/conference-app-2024/pull/55/files#diff-dab703910b2b2510b69f920f33cad2af49b1b411ed63635abf86d494d1f3f6db

@mikanIchinose
Copy link
Contributor Author

mikanIchinose commented Jul 4, 2024 •
edited
Loading

@takahirom

Thank you for your feedback!
I'm not familiar with screenshot testing, so I will address it in this issue.
Once I become familiar with it, I will start by writing screenshot tests.

@mikanIchinose mikanIchinose merged commit 1177eb3 into main Jul 4, 2024
2 checks passed
@mikanIchinose mikanIchinose deleted the feature/86 branch July 4, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees

@mikanIchinose mikanIchinose

Labels
type:feature ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add empty profilecard module
3 participants
@mikanIchinose @charles-b-stb @takahirom