Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addDispatcherV2 -> addDispatcher #152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Quat3rnion
Copy link

Fixes build for latest HyprlandAPI

@zjeffer
Copy link
Collaborator

zjeffer commented Jan 15, 2025

In c75ec3a I changed addDispatcher to addDispatcherV2 because addDispatcher became deprecated. I don't understand what this PR does? Change it back to the deprecated version?

See the github action output:

[1/2] Compiling C++ object libsplit-monitor-workspaces.so.p/src_main.cpp.o
../src/main.cpp: In function ‘PLUGIN_DESCRIPTION_INFO pluginInit(void*)’:
../src/main.cpp:364:31: warning: ‘bool HyprlandAPI::addDispatcher(void*, const std::string&, std::function<void(std::__cxx11::basic_string<char>)>)’ is deprecated [-Wdeprecated-declarations]
  364 |     HyprlandAPI::addDispatcher(PHANDLE, "split-workspace", splitWorkspace);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/hyprland/src/managers/HookSystemManager.hpp:12,
                 from /usr/include/hyprland/src/Compositor.hpp:20,
                 from ../src/main.cpp:3:
/usr/include/hyprland/src/plugins/PluginAPI.hpp:242:33: note: declared here
  242 |     APICALL [[deprecated]] bool addDispatcher(HANDLE handle, const std::string& name, std::function<void(std::string)> handler);
      |                                 ^~~~~~~~~~~~~
../src/main.cpp:365:31: warning: ‘bool HyprlandAPI::addDispatcher(void*, const std::string&, std::function<void(std::__cxx11::basic_string<char>)>)’ is deprecated [-Wdeprecated-declarations]
  365 |     HyprlandAPI::addDispatcher(PHANDLE, "split-cycleworkspaces", splitCycleWorkspaces);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/hyprland/src/plugins/PluginAPI.hpp:242:33: note: declared here
  242 |     APICALL [[deprecated]] bool addDispatcher(HANDLE handle, const std::string& name, std::function<void(std::string)> handler);
      |                                 ^~~~~~~~~~~~~
../src/main.cpp:366:31: warning: ‘bool HyprlandAPI::addDispatcher(void*, const std::string&, std::function<void(std::__cxx11::basic_string<char>)>)’ is deprecated [-Wdeprecated-declarations]
  366 |     HyprlandAPI::addDispatcher(PHANDLE, "split-movetoworkspace", splitMoveToWorkspace);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/hyprland/src/plugins/PluginAPI.hpp:242:33: note: declared here
  242 |     APICALL [[deprecated]] bool addDispatcher(HANDLE handle, const std::string& name, std::function<void(std::string)> handler);
      |                                 ^~~~~~~~~~~~~
../src/main.cpp:367:31: warning: ‘bool HyprlandAPI::addDispatcher(void*, const std::string&, std::function<void(std::__cxx11::basic_string<char>)>)’ is deprecated [-Wdeprecated-declarations]
  367 |     HyprlandAPI::addDispatcher(PHANDLE, "split-movetoworkspacesilent", splitMoveToWorkspaceSilent);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/hyprland/src/plugins/PluginAPI.hpp:242:33: note: declared here
  242 |     APICALL [[deprecated]] bool addDispatcher(HANDLE handle, const std::string& name, std::function<void(std::string)> handler);
      |                                 ^~~~~~~~~~~~~
../src/main.cpp:368:31: warning: ‘bool HyprlandAPI::addDispatcher(void*, const std::string&, std::function<void(std::__cxx11::basic_string<char>)>)’ is deprecated [-Wdeprecated-declarations]
  368 |     HyprlandAPI::addDispatcher(PHANDLE, "split-changemonitor", splitChangeMonitor);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/hyprland/src/plugins/PluginAPI.hpp:242:33: note: declared here
  242 |     APICALL [[deprecated]] bool addDispatcher(HANDLE handle, const std::string& name, std::function<void(std::string)> handler);
      |                                 ^~~~~~~~~~~~~
../src/main.cpp:369:31: warning: ‘bool HyprlandAPI::addDispatcher(void*, const std::string&, std::function<void(std::__cxx11::basic_string<char>)>)’ is deprecated [-Wdeprecated-declarations]
  369 |     HyprlandAPI::addDispatcher(PHANDLE, "split-changemonitorsilent", splitChangeMonitorSilent);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/hyprland/src/plugins/PluginAPI.hpp:242:33: note: declared here
  242 |     APICALL [[deprecated]] bool addDispatcher(HANDLE handle, const std::string& name, std::function<void(std::string)> handler);
      |                                 ^~~~~~~~~~~~~
[2/2] Linking target libsplit-monitor-workspaces.so

@zjeffer zjeffer self-assigned this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants