Changemonitor wrapping behavior (fixed with mirrored/removed monitors) #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duckonaut
requested changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves upon #45 (I couldn't push to that PR so I'm creating a new one).
I have a mirrored display which gets ID 1, while my other monitors have ID 0, 2, 3. #45 didn't work for me because it tried to move my workspace to a monitor that had an ID, but didn't actually 'exist' (because it's mirrored to the monitor with ID 3).
I think the same bug would happen if you remove a monitor.
CC @UwUnyaa
closes #41