Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Hyprland's SharedPtr from std::shared_ptr #74

Merged
merged 1 commit into from
May 7, 2024

Conversation

Duckonaut
Copy link
Owner

Fixes a build breakage caused by Hyprland PR #5883.

Not pinning anything yet as this is just a -git thing for now.

@Duckonaut Duckonaut merged commit 05b878f into main May 7, 2024
1 check passed
@Duckonaut Duckonaut deleted the fix/hyprland-shared-ptr branch May 8, 2024 12:05
@zjeffer
Copy link
Collaborator

zjeffer commented May 8, 2024

Looking at the CI/CD, this issue was visible 3 days ago:

image

I wonder if there's a way to get notified that certain GitHub Actions fail? That way we can very quickly fix the issue whenever we get a notification.

@Duckonaut
Copy link
Owner Author

I'll admit I noticed it, although I was out of town at the time. I have a Discord webhook set up for this because GitHub is pretty bad at notifications. I recommend setting one up in a private server, or I can invite you to the one with my setup, it's literally just for that anyway lol

@zjeffer
Copy link
Collaborator

zjeffer commented May 8, 2024

Ah great, sure you can add me, my username is the same as my GitHub: zjeffer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants