Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android RN 73 Support - Update build.gradle w/ Namespace #996

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexhernandez
Copy link

@alexhernandez
Copy link
Author

@DylanVann any MR feedback welcome

@saif-o99
Copy link

Hey @alexhernandez, what could this fix? because the lib works fine for me without it with latest RN

@alexhernandez alexhernandez changed the title Android RN 72 Support - Update build.gradle w/ Namespace Android RN 73 Support - Update build.gradle w/ Namespace Jul 31, 2023
@alexhernandez
Copy link
Author

Hey @alexhernandez, what could this fix? because the lib works fine for me without it with latest RN

I updated MR title. It's an update for RN 73. See links in description

@akimaleo
Copy link

It's absolutely needed to be merged and released

@felipecsl
Copy link

you'll also need to remove the package attribute from AndroidManifest.xml

@Himatheja
Copy link

FAILURE: Build failed with an exception.

  • What went wrong:
    A problem occurred configuring project ':react-native-fast-image'.

Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

 If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants