-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EAMxx: Modify microphysics interface to include sethet (washout rates) #3120
EAMxx: Modify microphysics interface to include sethet (washout rates) #3120
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟠 Enforce checks passingWaiting checks:
|
@odiazib has moved this PR from E3SM to Scream as E3SM is missing a PR that this PR depends upon. Hopefully, we can merge it before we merge the repos (E3SM and Scream). |
Leave it open. After the next merge from scream to E3SM, you should have what you need. |
Which PR exactly do you need? |
We need PR #3108 |
…ne test is sensitive to changes in the interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of relevant changes (and the original code development) were made in the mamxx (external) repo:
- https://github.com/eagles-project/mam4xx/blob/fdbb0816c5c0c541265ec17f544908da935d8af6/src/mam4xx/mo_sethet.hpp
- https://github.com/eagles-project/mam4xx/blob/fdbb0816c5c0c541265ec17f544908da935d8af6/src/mam4xx/mo_gas_phase_chemdr.hpp
Therefore, there are only minor code changes in this repo. The EALGES team has performed simulations to test the new feature (w. vs. w/o) and the result (see above: to be posted) suggests the feature works as expected, at least qualitatively. On the other hand, we need more detailed evaluation of the aerosol/chemistry budget to make sure the sulfur chemistry and sulfate formation are reasonably simulated. This will need additional code implementation (for process rates output at multiple places) and significant effort for diagnostic tool development/adjustment, which is out of scope for this PR.
Thanks, Kai! I have uploaded the figures in the PR description. The PR Is failing the expected tests. CUDA tests are not running on AT. I have manually run a CUDA test on PM-GPU, and the standalone test (in single precision mode) ran fine without emitting any new warnings. |
An existing EAMxx interface (
eamxx_mam_microphysics_process_interface.cpp
) is modified to include the invocation of the washout rates for gases.Since the CMake option,
SCREAM_ENABLE_MAM
, is alwaysON
, these codes are always compiled with the EAMxx codebase, but this interface can be turned off/on using the namelist flags.Output variables
This process computes
het_rates
that are used in gas phase chemistryTesting
We have existing tests for this interface, so we didn't add any new tests. We have a suite of validation tests in the MAM4xx repo to validate
sethet
processThe
atmchange
command to invoke this process in a CIME simulation is:./atmchange physics::atm_procs_list="mac_aero_mic,rrtmgp,mam4_aero_microphys
To set up a test with the above configuration, use the following commands:
Where,
<machine>
is the machine name<compiler>
is the compiler to use on the machine<test id >
is a unique string test identifier<project id>
is the allocation project to chargescream-mam4xx-aero_microphysics
is the test modifier that addsmam4_aero_microphys
to theatm_procs_list
process list and increases the number of tracers to 41.For
ne30pg2
grid, use the following command:New input data
No new input data
Figures from model analysis
We ran a simulation using ne30 grid with only microphysics process turned on. Here are the gas and aerosol species burden with (labeled
sethet
) and without (labeledctl
) the sethet process:Standalone Test Timings (Compy):
We will upload the timings once the PR is reviewed and approved