Validate sample check when VCF contains aggregated genotypes #233
+57
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcezard
force-pushed
the
skip_sample_check
branch
from
560f5a6 to
959697c
Compare
apriltuesday
approved these changes
Jan 9, 2025
| metadata_file = os.path.join(self.resources_folder, 'metadata_2_analysis_same_samples.xlsx') | ||
| self.validation.eload_cfg.set('submission', 'metadata_spreadsheet', value=metadata_file) | ||
| self.validation.eload_cfg.set('validation', 'sample_check', value={}) | ||
| with patch.object(self.validation, '_get_dir', return_value=os.path.join(self.resources_folder, 'vcf_dir')): |
There was a problem hiding this comment.
This is fine for now, but I do think that if we want to allow the eload directory to be changed by individual tests, it would be better to allow the directory path to be optionally passed into the Eload object, and just constructing it from the config by default. It would make a few of these tests simpler - kind of like how we started allowing the config to be passed in rather than always reading it from file.
nitin-ebi
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests should pass once I rebase on top of #232