Remove redundant error_message state inits

ECP-WarpX · Jan 7, 2025 · 163b3c6 · 163b3c6
1 parent 7550126
commit 163b3c6
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 15 deletions.
diff --git a/src/python/impactx/dashboard/Input/csrConfiguration/csrMain.py b/src/python/impactx/dashboard/Input/csrConfiguration/csrMain.py
@@ -11,7 +11,6 @@
 # -----------------------------------------------------------------------------
 
 state.csr_bins = generalFunctions.get_default("csr_bins", "default_values")
-state.csr_bins_error_message = ""
 
 # -----------------------------------------------------------------------------
 #
@@ -20,8 +19,9 @@
 
 @state.change("csr_bins")
 def on_csr_bins_change(csr_bins, **kwargs):
-    error_message = generalFunctions.validate_against(csr_bins, "int", ["positive"])
-    state.csr_bins_error_message = error_message
+    state.csr_bins_error_message = generalFunctions.validate_against(
+        csr_bins, "int", ["positive"]
+    )
     generalFunctions.update_simulation_validation_status()
 
 

diff --git a/src/python/impactx/dashboard/Input/inputParameters/inputMain.py b/src/python/impactx/dashboard/Input/inputParameters/inputMain.py
@@ -84,12 +84,6 @@ def __init__(self):
         state.charge_qe = generalFunctions.get_default("charge_qe", "default_values")
         state.mass_MeV = generalFunctions.get_default("mass_MeV", "default_values")
 
-        state.npart_error_message = []
-        state.kin_energy_error_message = []
-        state.bunch_charge_C_error_message = []
-        state.mass_MeV_error_message = []
-        state.charge_qe_error_message = []
-
     def card(self):
         """
         Creates UI content for beam properties.

diff --git a/src/python/impactx/dashboard/Input/latticeConfiguration/latticeMain.py b/src/python/impactx/dashboard/Input/latticeConfiguration/latticeMain.py
@@ -36,7 +36,6 @@
 state.selectedLattice = generalFunctions.get_default("lattice", "default_values")
 state.selectedLatticeList = []
 state.nslice = generalFunctions.get_default("n_slice", "default_values")
-state.nslice_error_message = ""
 state.lattice_configuration_dialog_settings = False
 
 # -----------------------------------------------------------------------------

diff --git a/src/python/impactx/dashboard/Input/space_charge_configuration/spaceChargeMain.py b/src/python/impactx/dashboard/Input/space_charge_configuration/spaceChargeMain.py
@@ -43,10 +43,6 @@
 state.mlmg_max_iters = generalFunctions.get_default("mlmg_max_iters", "default_values")
 state.mlmg_verbosity = generalFunctions.get_default("mlmg_verbosity", "default_values")
 
-state.mlmg_relative_tolerance_error_message = ""
-state.mlmg_absolute_tolerance_error_message = ""
-state.mlmg_max_iters_error_message = ""
-state.mlmg_verbosity_error_message = ""
 state.space_charge_dialog_settings = False
 # -----------------------------------------------------------------------------
 # Helper functions

diff --git a/src/python/impactx/dashboard/Input/trameFunctions.py b/src/python/impactx/dashboard/Input/trameFunctions.py
@@ -64,7 +64,7 @@ def text_field(label, v_model_name, **kwargs):
         vuetify.VTextField(
             label=label,
             v_model=(f"{v_model_name}",),
-            error_messages=(f"{v_model_name}_error_message",),
+            error_messages=(f"{v_model_name}_error_message", []),
             type="number",
             step=generalFunctions.get_default(f"{v_model_name}", "steps"),
             suffix=generalFunctions.get_default(f"{v_model_name}", "units"),