-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MADX Input Parser #214
Conversation
Hey @ax3l, should I make the chicane input look like the one from Also, the |
@n01r as discussed yesterday, can you please adjust the |
examples/chicane/input_chicane.madx
Outdated
! TODO make this work with inline calculations | ||
! theta=pi/10.; | ||
! TODO put theta again everywhere after `angle=` with its right sign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @np-eazy fyi :)
c2a7738
to
f6cf8eb
Compare
Using Andreas Adelmann's pymadxparser
for more information, see https://pre-commit.ci
Co-authored-by: Axel Huebl <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Use proper regex literals. Avoids: ``` DeprecationWarning: invalid escape sequence \( ``` et al.
and adjust formatting
Caution: Examples still not working again
8251e74
to
39a735b
Compare
39a735b
to
f88d685
Compare
to avoid matching of `drift` in `use, sequence` line with parser.
6f75edf
to
1260242
Compare
change MADXParser Quad type to Quadrupole to stay consistent with MADX input
1260242
to
5f80f37
Compare
Confirmed today via email :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 ✨
also fix energy conversion in madx_to_impactx
This PR adds a first MAD-X (Methodical Accelerator Design) input capability to ImpactX (#104).
We use the pymadxparser that Andreas Adelmann (PSI) generously made available for us. 🎉
madx_to_impactx
__init__.py
Follow-up features
40.d-3
)