Update AMReX and pyAMReX dependencies. #760
Conversation
|
I seem to recall that we previously had problems on Windows with FFTW libraries related to the 1D FFT that Alex was using for the CSR solve, which were avoided when Alex switched from using FFTW to anyfft. |
| #else() | ||
| # set(AMReX_FFT OFF CACHE INTERNAL "") | ||
| #endif() | ||
|
|
There was a problem hiding this comment.
This is a commented duplicate of 40-44, because I wasn't sure of the best place to put this.
There was a problem hiding this comment.
I'll add this control to #790, thanks!
|
I will address the Windows build issue by porting our ImpactX/WarpX/HiPACE++ FFTW CMake find script to AMReX: |
Update API signature
|
@WeiqunZhang @atmyers we need to update this to finalize #743 but there are three AMReX issues blocking it:
|
## Summary This improves the FFTW CMake find logic based on the scripts that I developed for HiPACE++/WarpX/ImpactX to find FFTW on various platforms. It helps to find FFTW on Windows, where it is installed by default with CMake, and it uses more details from PkgConfig files on Linux/macOS, such as forwarding defines, using OpenMP acceleration if available. It also chooses sensible defaults to work around known FFTW build system bugs, linked inline. There are also options added to control the defaults, e.g., in package managers that use a different default (e.g., CMake FFTW install on Linux/macOS). ## Additional background See build issues in ECP-WarpX/impactx#760 (comment) On Windows, try searching for `FFTW3(f)Config.cmake` files first, because: - Installed `.pc` files wrongly and unconditionally add `-lm` - FFTW/fftw3#236 On Linux & macOS, the Autotools install tries to emulate a CMake config file, but has a bug: - FFTW/fftw3#235 - Thus, by default rely on `.pc` files because we cannot know which install was choosen (otherwise, there is an option for it named `AMReX_FFTW_SEARCH`). ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [x] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
|
Will update in 25.01 release PR #790 and following PRs. |
Update AMReX, ABLASTR, pyAMReX dependencies to the latest development, to use updated WarpX IGF solver exploiting new AMReX FFT: ECP-WarpX/WarpX#5457